Convert Json object to entity

Question

I would like to see some of your suggestions on how to build entities in C# to fit this Json

{  
"activities-heart": [
    {
      "dateTime": "2016-10-25",
      "value": {
        "customHeartRateZones": [],
        "heartRateZones": [
          {
            "max": 88,
            "min": 30,
            "name": "Out of Range"
          },
          {
            "max": 123,
            "min": 88,
            "name": "Fat Burn"
          },
          {
            "max": 150,
            "min": 123,
            "name": "Cardio"
          },
          {
            "max": 220,
            "min": 150,
            "name": "Peak"
          }
        ]
      }
    }
  ],
  "activities-heart-intraday": {
    "dataset": [],
    "datasetInterval": 1,
    "datasetType": "minute"
  }
}

This Site suggested:

public class HeartRateZone
{
    public int max { get; set; }
    public int min { get; set; }
    public string name { get; set; }
}

public class Value
{
    public List<object> customHeartRateZones { get; set; }
    public List<HeartRateZone> heartRateZones { get; set; }
}

public class ActivitiesHeart
{
    public string dateTime { get; set; }
    public Value value { get; set; }
}

public class ActivitiesHeartIntraday
{
    public List<object> dataset { get; set; }
    public int datasetInterval { get; set; }
    public string datasetType { get; set; }
}

public class RootObject
{
    public List<ActivitiesHeart> __invalid_name__activities-heart { get; set; }
    public ActivitiesHeartIntraday __invalid_name__activities-heart-intraday { get; set; }
}

My problem is that this returns nothing, it tries to build the entities but they are null. Is there something that the converter and i don't see.

"My problem is that this returns nothing, it tries to build the entities but they are null." returns nothing when? Where's your code to deserialize the JSON? — Matt Burland
– Matt Burland, Commented Oct 25, 2016 at 12:38

Gilad Green · Accepted Answer · 2016-10-25 12:52:24Z

2

Assuming you are using NewtonSoft to deserialize the json (and pretty sure that the following is also correct to other deserializers) the problem is with your classes.

If for your classes I run the following line, as you described I get null values in the properties.

var result = JsonConvert.DeserializeObject<RootObject>(jsonString);

Now if you look at the classes you have they don't even compile:

public class RootObject
{
    public List<ActivitiesHeart> __invalid_name__activities-heart { get; set; }
    public ActivitiesHeartIntraday __invalid_name__activities-heart-intraday { get; set; }
}

And the website even told you that the property names are invalid: __invalid_name__activities-heart. You can't have property names with - in them..

To fix it you need to:

Change the property names in the classes to valid names + update json with new names:

public class RootObject
{
    public List<ActivitiesHeart> ActivitiesHeart { get; set; }
    public ActivitiesHeartIntraday ActivitiesHeartIntraday { get; set; }
}

Or better, change property names and then as Jim suggested use the JsonPropertyAttribute:

public class RootObject
{
    [JsonProperty("activities-heart")]
    public List<ActivitiesHeart> ActivitiesHeart { get; set; }
    [JsonProperty("activities-heart-intraday")]
    public ActivitiesHeartIntraday ActivitiesHeartIntraday { get; set; }
}

it will work

edited Oct 25, 2016 at 12:52

answered Oct 25, 2016 at 12:43

Gilad Green

37.3k7 gold badges67 silver badges99 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jim Over a year ago

How about [JsonProperty("activities-heart")] and [JsonProperty("activities-heart-intraday")] ?

Jimmy Lillegaard · Accepted Answer · 2016-10-26 06:20:12Z

0

Thnx with the JsonProperty it worked right away.

Belowis the way Icall the api and deserialize, just if anyone else need the help.

var apiCall = ToFullUrl("/1/user/{0}/activities/heart/date/{1}/{2}.json", encodedUserId, ToFitbitFormat(startDate), ToFitbitFormat(endDateOrPeriod));
HttpResponseMessage response = await HttpClient.GetAsync(apiCall);
await HandleResponse(response);string responseBody = await response.Content.ReadAsStringAsync();
RootObject entity = JsonConvert.DeserializeObject<RootObject>(responseBody);

answered Oct 26, 2016 at 6:20

Jimmy Lillegaard

1291 silver badge9 bronze badges

Collectives™ on Stack Overflow

Convert Json object to entity

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related