angular 2 undefined variable

Question

@Component({
    selector: 'login-page',
    templateUrl: 'login-page.html'
})
export class LoginPage {

    username: string;
    password: string;
    firm: string;
    response : boolean;


    constructor(public navCtrl: NavController, public authService: Auth, public loadingCtrl: LoadingController) {

    }

 login(){
           let credentials = [this.username, this.password, this.firm];
           this.authService.login(credentials)
           .subscribe(
               data => this.response = data.login,
               error => alert(error),
               () => console.log("Finished")
           );
           alert(this.response);
           if(this.response){
               this.navCtrl.setRoot(HomePage);
           }else{
               alert("check your credentials");
           }
        }

I am trying to change the login page to home page. My rest gives me the json response like following;

{"login":true} --- if credentials are true

{"login":false} --- if credentials are false

so at this point I have two question;

1) Can I take just the boolean part of the response and set the this.response to it like in the code?

2) When I alert the response object to check its settled correctly or not, I see that response is still "undefined". I tried to set it initially to false but this line data => this.response = data.login does not change its value.

Günter Zöchbauer · Accepted Answer · 2016-10-25 13:24:59Z

1

The code alert(this.response); and below is executed before the response from authService.login() arrives.

You need to move the code inside the callback passed to subscribe

    login(){
       let credentials = [this.username, this.password, this.firm];
       this.authService.login(credentials)
       .subscribe(
           data => {
             this.response = data.login;
               alert(this.response);
               if(this.response){
                   this.navCtrl.setRoot(HomePage);
               }else{
                   alert("check your credentials");
               }
           },
           error => alert(error),
           () => console.log("Finished")
       );
    }

answered Oct 25, 2016 at 13:24

Günter Zöchbauer

661k235 gold badges2.1k silver badges1.6k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

cnian Over a year ago

yess man, I will definitely accept this answer but you are faster than the stackoverflow can accept :) you should wait for couple of minutes. Thanks a lot man

Collectives™ on Stack Overflow

angular 2 undefined variable

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related