Adding simple counter variable to my ACF Repeater loop

Question

I am trying to add a simple counter variable to my ACF Repeater loop for an accordion but am getting an error. Can anyone offer some assistance? Thanks!

<?php
$counter = 0; if( have_rows('faq') ):$counter++; ?>    

                    <section class="ac-container">

                        <?php while( have_rows('faq') ): the_row(); 

                            $question = get_sub_field('faq_question');
                            $answer = get_sub_field('faq_answer');
                            ?>    
                                <div>
                                    <input id="ac-<?php echo $counter;?>" name="accordion-1" type="radio" checked />
                                    <label for="ac-<?php echo $counter;?>"><?php echo $question; ?></label>
                                    <article class="ac-small"><?php echo $answer; ?></article>
                                </div>    

                        <?php endwhile; ?>    
                    </section>    
                <?php endif; ?>

The input id's are all the same so the counter loop doesn't seem to be ascending using <?php echo $counter;?> — Lisa Jaffé
– Lisa Jaffé, Commented Nov 2, 2016 at 10:25

Milap · Accepted Answer · 2016-11-02 11:11:18Z

5

Try like this

<?php
        if( have_rows('faq') ):$counter = 0;?>
            <section class="ac-container">
                <?php while( have_rows('faq') ): the_row();
                    $question = get_sub_field('faq_question');
                    $answer = get_sub_field('faq_answer');
                    ?>
                    <div>
                        <input id="ac-<?php echo $counter;?>" name="accordion-1" type="radio" checked />
                        <label for="ac-<?php echo $counter;?>"><?php echo $question; ?></label>
                        <article class="ac-small"><?php echo $answer; ?></article>
                    </div>
                    <?php $counter++; endwhile; ?>

            </section>
        <?php endif; ?>

edited Nov 2, 2016 at 11:11

Milap

7,2398 gold badges28 silver badges47 bronze badges

answered Nov 2, 2016 at 10:35

Narek Elbakyan

1824 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Alok Patel · Accepted Answer · 2016-11-02 10:27:12Z

$counter is not increasing because you're not incrementing it in while loop. Increment in while loop to look something like this,

<?php
$counter = 0; if( have_rows('faq') ): ?>


                <section class="ac-container">

                    <?php while( have_rows('faq') ): the_row(); 

                        $question = get_sub_field('faq_question');
                        $answer = get_sub_field('faq_answer');
                        $counter++;    // Increment it inside while loop.
                        ?>
                            <div>
                                <input id="ac-<?php echo $counter;?>" name="accordion-1" type="radio" checked />
                                <label for="ac-<?php echo $counter;?>"><?php echo $question; ?></label>
                                <article class="ac-small"><?php echo $answer; ?></article>
                            </div>


                    <?php endwhile; ?>

                </section>

            <?php endif; ?>

airdrumz · Accepted Answer · 2016-11-02 10:31:37Z

0

Your $counter variable is not inside your loop so won't increase with each iteration. Try this:

<?php
$counter = 0; if( have_rows('faq') ): ?>


<section class="ac-container">

    <?php while( have_rows('faq') ): the_row(); 

        $counter++; // this is now in the while loop
        $question = get_sub_field('faq_question');
        $answer = get_sub_field('faq_answer');
        ?>

        <div>
            <input id="ac-<?php echo $counter;?>" name="accordion-1" type="radio" checked />
            <label for="ac-<?php echo $counter;?>"><?php echo $question; ?></label>
            <article class="ac-small"><?php echo $answer; ?></article>
        </div>


    <?php endwhile; ?>

</section>

<?php endif; ?>

edited Nov 2, 2016 at 10:31

answered Nov 2, 2016 at 10:26

airdrumz

4495 silver badges9 bronze badges

Collectives™ on Stack Overflow

Adding simple counter variable to my ACF Repeater loop

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related