Laravel Foreach Controller vs View

Question

I realized something I can't figure out by myself.

I get a different result when I loop through first in a Controller and pass then the result to my view. Versus loop straight in my view.

For instance: I have this in my Controller:

  public function index()
{
    $subscribers = Subscriber::where('user_id', Auth::user()->id)->orderBy('created_at','asc')->get();

    foreach ($subscribers as $key => $subscriber) {
      $var = $subscriber->name;
    }

    return view('backend.newsletter.contacts.index')->withSubscribers($subscribers)
                                                    ->withVar($var);
}

by using {{$var}} in my view I get only "John" as a result.

But when I use the foreach loop in my view instead of in the Controller:

@foreach($subscribers as $key => $subscriber)
 {{$subscriber->name}}
@endforeach

I get two results, "John" and "Dan". This makes totaly sense as I have two entries in my DB.

So how does it come that I get two different results here ?

Alexey Mezenin · Accepted Answer · 2016-11-02 14:11:52Z

5

When you're doing this:

foreach ($subscribers as $key => $subscriber) {
    $var = $subscriber->name;
}

With each iteration you overwrite $var so you always get the last value. For example, if you have ['Dan', 'John, 'Alice', 'Alan'], you'll get Alan.

Good practice is too pass data to a view and iterate it with @foreach.

answered Nov 2, 2016 at 14:11

Alexey Mezenin

164k27 gold badges309 silver badges287 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Wistar · Accepted Answer · 2016-11-02 14:12:31Z

0

Because only the last loop iteration is stored in $var.

You need to

$var = [];
foreach ($subscribers as $key => $subscriber) {
     $var[] = $subscriber->name;
}

answered Nov 2, 2016 at 14:12

Wistar

3,8105 gold badges48 silver badges71 bronze badges

Comments

Patrick · Accepted Answer · 2016-11-02 14:14:08Z

0

You are overriding $var in the loop.

Try this:

$var = []; foreach ($subscribers as $key => $subscriber) { $var[] = $subscriber->name; // Appends name to array }

answered Nov 2, 2016 at 14:14

Patrick

2131 silver badge9 bronze badges

Collectives™ on Stack Overflow

Laravel Foreach Controller vs View

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related