insert query syntax problem

Question

i have a SQL query as follows

  String S = Editor1.Content.ToString();
     Response.Write(S);   
    string sql = "insert into testcase.ishan(nmae,orders) VALUES ('9',@S)";
   OdbcCommand cmd = new OdbcCommand(sql, myConn);
            cmd.Parameters.AddWithValue("@S", S); 
            cmd.ExecuteNonQuery();

Error: Column 'orders' cannot be null at System.Data.Odbc.OdbcConnection.HandleError

Peter · Accepted Answer · 2010-10-28 09:53:39Z

3

Better to use something like:

var sqlCommandText = "insert into testcase.ishan(nmae,orders) VALUES ('9', @S)";
using (var connection = new SqlConnection())
{
    using (var command = new SqlCommand(sqlCommandText , connection))
    {
        command.Parameters.AddWithValue("@S", S);
        command.ExecuteNonQuery();
    }
}

The use of parameters prevents SQL injection. Andrews solution does not, I believe.

ExecuteNonQuery() will return the number of rows affected, if you need it.

The using statements will take care of disposing the connection properly, so afterwards, you have no open connections anymore. This is because SqlConnection implements IDisposable.

edited Oct 28, 2010 at 9:53

answered Oct 28, 2010 at 9:48

Peter

14.2k11 gold badges82 silver badges130 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Ninad Over a year ago

The type or namespace name 'SqlConnection' could not be found

Dr TJ Over a year ago

add this using: using System.Data.SqlClient;

Peter Over a year ago

You should reference/import/using System.Data.SqlClient. See: msdn.microsoft.com/en-us/library/…

Ninad Over a year ago

i am getting this error Column 'orders' cannot be null at System.Data.Odbc.OdbcConnection.HandleError

Dr TJ Over a year ago

@user486050: have you ever set any value for S?

|

Collectives™ on Stack Overflow

insert query syntax problem

1 Answer 1

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related