javascript array date error

Question

I am a bit confused about this one.

This piece of code works well but has strange behavior.

var tmpcurdte = eval(dataSource[i].startDate);
tmpcurdte.setDate(tmpcurdte.getDate() + 1);

while (tmpcurdte < tmpenddte) {
  console.log("block date: " + tmpcurdte);
  blockdayarray[blockdayarray.length] = tmpcurdte;
  console.log("blockdayarray: " + blockdayarray);
  tmpcurdte.setDate(tmpcurdte.getDate() + 1);
}

Output

block date :Sat Nov 12 2016 00:00:00 GMT+0100 (CET)
blockdayarray :**Sat Nov 12** 2016 00:00:00 GMT+0100 (CET)
block date :Sat Dec 31 2016 00:00:00 GMT+0100 (CET)
blockdayarray :**Sun Nov 13** 2016 00:00:00 GMT+0100 (CET),**Sat Dec 31** 2016 00:00:00 GMT+0100 (CET)
block date :Sun Jan 01 2017 00:00:00 GMT+0100 (CET)
blockdayarray :Sun Nov 13 2016 00:00:00 GMT+0100 (CET),**Sun Jan 01 2017** 00:00:00 GMT+0100 (CET),**Sun Jan 01 2017** 00:00:00 GMT+0100 (CET)
block date :Sat Feb 04 2017 00:00:00 GMT+0100 (CET)
blockdayarray :Sun Nov 13 2016 00:00:00 GMT+0100 (CET),Mon Jan 02 2017 00:00:00 GMT+0100 (CET),**Mon Jan 02 2017** 00:00:00 GMT+0100 (CET),Sat Feb 04 2017 00:00:00 GMT+0100 (CET)

As you can see the previous date in the array changes when I push a new one. Can anyone help/explain this?

why are you doing the eval thing?

Arsalan Ahmad
– Arsalan Ahmad

2016-11-10 08:47:26 +00:00
Commented Nov 10, 2016 at 8:47 — Arsalan Ahmad
– Arsalan Ahmad, Commented Nov 10, 2016 at 8:47
read below. thx for taking the time to explorer my code :-)

user3242509
– user3242509

2016-11-10 09:19:33 +00:00
Commented Nov 10, 2016 at 9:19 — user3242509
– user3242509, Commented Nov 10, 2016 at 9:19

T.J. Crowder · Accepted Answer · 2016-11-10 08:39:40Z

1

It's because you're pushing the same Date object onto the array repeatedly, and changing its state.

Instead, you want to create a new Date object for the next day:

var tmpcurdte = eval(dataSource[i].startDate);
tmpcurdte.setDate(tmpcurdte.getDate()+1);

while (tmpcurdte < tmpenddte) {
    console.log("block date :" + tmpcurdte);
    blockdayarray[blockdayarray.length]=tmpcurdte;
    console.log("blockdayarray :" + blockdayarray);
    tmpcurdte = new Date(tmpcurdte.getTime());     // ***
    tmpcurdte.setDate(tmpcurdte.getDate() + 1);
}

Side note: I'm not quite sure what you're doing with that call to eval, but there's almost certainly a better way to do whatever it is you have that doing.

answered Nov 10, 2016 at 8:39

T.J. Crowder

1.1m201 gold badges2k silver badges2k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user3242509 Over a year ago

Excellent,Your solution works fine. i also tough it was a reference thing but couldn’t figure it out . the eval is to parse a php returned date string as a date object. <br>I will change it afterwards but for now it works fine. i need this date object in a widget thx for your help, B

Collectives™ on Stack Overflow

javascript array date error

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related