Getting null array first and then getting actual result in php

Question

In my script i am fetching data from database and storing it in array and output it in json. Everything is going correct just the first array I am getting is null and then the second array has the correct data. I don't understand why am I getting first null array.

My problem solves if I get correct result in array without the null array. Here is the output I am getting

[[],{"url":"example.com\/sign_pdf\/PDFSign.pdf","name":"PDFSign.pdf","signer":"aman","sequence":"1","message":"Hello","flag":"0"}]

I don't need First null array. Why the hell am I getting that.

Here is the code.

if(($_GET['action'])&&($_GET['username'])&&($_GET['key'])) {
    $select = $_GET['action'];
    $username =$_GET['username']; //no default
    $key= $_GET['key'];

    if($key=='abcxyz'){
        if($select=='select'){
            /* connect to the db */
            $connect = mysqli_connect('localhost','root','')or die("Couldn't connect to database!");
            mysqli_select_db($connect,'sign') or die ("Couldn't find database");         

            $query ="SELECT * FROM path WHERE signer ='$username' ";

            $result = mysqli_query($connect,$query);
            $numrows=mysqli_num_rows($result);
            $posts[] = array();

            if($numrows!==0) {

                while($row = mysqli_fetch_array($result)) {
                    $post['url'] = $row['url'];
                    $post['name'] = $row['name'];
                    $post['signer'] = $row['signer'];
                    $post['sequence'] = $row['sequence'];
                    $post['message'] = $row['message'];
                    $post['flag'] = $row['flag'];
                    array_push($posts, $post);
                }

                header('Content-type: application/json');
                echo json_encode($posts); 

            }
        }
    }
}

Instead of $posts[] = array(); use $posts = array();

L. Herrera
– L. Herrera

2016-11-15 12:16:41 +00:00
Commented Nov 15, 2016 at 12:16 — L. Herrera
– L. Herrera, Commented Nov 15, 2016 at 12:16

Aniket Sahrawat · Accepted Answer · 2016-11-15 12:23:38Z

1

You are creating array(array()) by $posts[] = array();

Replace this:

$posts[] = array();

with

$posts = array();

$posts = array(); will create a null array() and not array(array())

edited Nov 15, 2016 at 12:23

answered Nov 15, 2016 at 12:18

Aniket Sahrawat

13k3 gold badges44 silver badges69 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

James Paterson · Accepted Answer · 2016-11-15 12:19:02Z

1

Instead of

$posts[] = array();

Which assigns an array to the first element of $posts, use

$posts = array();

Which initialises the variable, what I think you are trying to do.

answered Nov 15, 2016 at 12:19

James Paterson

2,9533 gold badges33 silver badges43 bronze badges

1 Comment

Xorifelse Over a year ago

Or, leave that line out as its not required.

Nikhil Vaghela · Accepted Answer · 2016-11-15 12:21:53Z

1

Your $posts[]=array() should be like $posts=array() And append $post into $posts using $posts[]=$post .

$posts = array();
if ($numrows !== 0) {
    while ($row = mysqli_fetch_array($result)) {
        $post = array();
        $post['url'] = $row['url'];
        $post['name'] = $row['name'];
        $post['signer'] = $row['signer'];
        $post['sequence'] = $row['sequence'];
        $post['message'] = $row['message'];
        $post['flag'] = $row['flag'];
        $posts[] = $post;
    }
}

edited Nov 15, 2016 at 12:21

answered Nov 15, 2016 at 12:16

Nikhil Vaghela

2,0942 gold badges18 silver badges30 bronze badges

Comments

raphael75 · Accepted Answer · 2016-11-15 12:18:50Z

0

You should remove the $posts array. The array_push($posts, $post) is basically taking your empty $posts array and adding the $post array to it.

answered Nov 15, 2016 at 12:18

raphael75

3,2686 gold badges35 silver badges49 bronze badges

Collectives™ on Stack Overflow

Getting null array first and then getting actual result in php

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related