Return JSON Using Map

Question

I have a method, which changes the status from 'Active' to 'InActive' and vice

versa, of a record, by fetching it's id.

Now, I want to convert it to return a ResponseEntity object, inside which, I have a map stored

When I test my method, I get a 400: Bad Request

////////////////////////Old Method////////////////

@RequestMapping("toggleStatus")
    public @ResponseBody void toggleStatus(@RequestParam("resourceId") Long resourceId ){
        ResourceElementMaster resourceElementMaster = resourceElementService.findById(resourceId);
        if(resourceElementMaster.getIsActive() == true) {
            resourceElementMaster.setIsActive(false);
        } else {
            resourceElementMaster.setIsActive(true);
        }
        resourceElementService.update(resourceElementMaster);
    }

//////////////////////New Method/////////////////////////////

@RequestMapping(value="toggleStatus",method=RequestMethod.PUT)
    public @ResponseBody ResponseEntity<Map<String, Object>> toggleStatus(@RequestBody Long resourceId ){
        Map<String, Object> mapToggle=new HashMap<String, Object>();
        ResourceElementMaster resourceElementMaster = resourceElementService.findById(resourceId);
        if(resourceElementMaster.getIsActive() == true) {
            resourceElementMaster.setIsActive(false);
        } else {
            resourceElementMaster.setIsActive(true);
        }
        mapToggle.put("Update",resourceElementService.update(resourceElementMaster));
        return new ResponseEntity<Map<String, Object>>(mapToggle, HttpStatus.OK) ;
    }

How do I solve this??

The JSON which I pass, to test this method, is : { "resourceId": 57, "isActive":true } — user7005380
– user7005380, Commented Nov 16, 2016 at 10:18

devops · Accepted Answer · 2016-11-16 11:16:34Z

1

You problem is, you are trying to pass an json to your /toggleStatus Method. But your @Controller accepts only a resourceIdof type Long.

So your response via Postman should be something like this:

PUT http://localhost:8080/toggleStatus?resouceId=42

also, there is no need for RequestEntity in your case. Modify your @controller like this:

@ResponseBody 
@RequestMapping(value = "toggleStatus", method = RequestMethod.PUT)
public Object toggleStatus(@RequestParam Long resourceId ){
    Map<String, Object> mapToggle = new HashMap<String, Object>();
    ResourceElementMaster resourceElementMaster = resourceElementService.findById(resourceId);
    resourceElementMaster.setIsActive(!resourceElementMaster.getIsActive());
    mapToggle.put("Update", resourceElementService.update(resourceElementMaster));
    return mapToggle;
}

edited Nov 16, 2016 at 11:16

answered Nov 16, 2016 at 10:24

devops

9,2016 gold badges51 silver badges77 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

user7005380 Over a year ago

Same : 400 Bad Request.

user7005380 Over a year ago

How do I test it?? I passed the following JSON in Postman : { "resourceId": 57, "version":1, "name":"Allegation1", "Active":true }

devops Over a year ago

Why you are passing a json? Your Controller accepts only a resourceId.

N V · Accepted Answer · 2016-11-16 11:16:37Z

Don't pass a json, you only need to pass the resourceId, which you are accepting as a parameter in your method toggleStatus.

Also, use @RequestParam, instead of @RequestBody :

@RequestMapping(value="toggleStatus",method=RequestMethod.POST)
public @ResponseBody ResponseEntity<Map<String, Object>> toggleStatus(@RequestParam(value = "resourceId") Long resourceId ){
    Map<String, Object> mapToggle=new HashMap<String, Object>();
    ResourceElementMaster resourceElementMaster = resourceElementService.findById(resourceId);
    if(resourceElementMaster.getIsActive() == true) {
        resourceElementMaster.setIsActive(false);
    } else {
        resourceElementMaster.setIsActive(true);
    }
    mapToggle.put("Update",resourceElementService.update(resourceElementMaster));
    return new ResponseEntity<Map<String, Object>>(mapToggle, HttpStatus.OK) ;
}

Collectives™ on Stack Overflow

Return JSON Using Map

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related