Javascript nested .each() function

Question

I try to create a calculator keypad. Onclick functions work properly. My problem is with .each() funtion. How can I traverse the my buttonArray ?. I could not handle the nested arrays and appends <p> to <div> as same <input> append to <p>.

My script is like:

var buttonArray = [
  [{
      type: 'button',
      className: 'sil',
      value: 'C'
    }, {
      type: 'button',
      className: 'hepsiniSil',
      value: 'AC'
    },

  ],
  [{
    type: 'button',
    className: 'buttons',
    value: '7'
  }, {
    type: 'button',
    className: 'buttons',
    value: '8'
  }, {
    type: 'button',
    className: 'buttons',
    value: '9'
  }, {
    type: 'button',
    className: 'buttons',
    value: '*'
  }],
  [{
    type: 'button',
    className: 'buttons',
    value: '4'
  }, {
    type: 'button',
    className: 'buttons',
    value: '5'
  }, {
    type: 'button',
    className: 'buttons',
    value: '6'
  }, {
    type: 'button',
    className: 'buttons',
    value: '-'
  }],
  [{
    type: 'button',
    className: 'buttons',
    value: '1'
  }, {
    type: 'button',
    className: 'buttons',
    value: '2'
  }, {
    type: 'button',
    className: 'buttons',
    value: '3'
  }, {
    type: 'button',
    className: 'buttons',
    value: '+'
  }],
  [{
    type: 'button',
    className: 'buttons',
    value: '0'
  }, {
    type: 'button',
    className: 'esit',
    value: '=',
    click: 'esittir'
  }, {
    type: 'button',
    className: 'buttons',
    value: '/'
  }]
]

$(document).ready(function() {
  $.each(function(index, buttonArray) {
    $("<p>").each(function(subIndex, subArrays) {
      $("<input>")
        .addClass(subArrays.className)
        .val(subArrays.val)
        .appendTo(this)
    });
  });
});

and I want to this output:

<p>
  <input type="button" class="sil" value="C" style="width:50px">
  <input type="button" class="hepsiniSil" value="AC" style="width:50px">
</p>
<p>
  <input type="button" class="buttons" value="7">
  <input type="button" class="buttons" value="8">
  <input type="button" class="buttons" value="9">
  <input type="button" class="buttons" value="*">
</p>
<p>
  <input type="button" class="buttons" value="4">
  <input type="button" class="buttons" value="5">
  <input type="button" class="buttons" value="6">
  <input type="button" class="buttons" value="-">
</p>
<p>
  <input type="button" class="buttons" value="1">
  <input type="button" class="buttons" value="2">
  <input type="button" class="buttons" value="3">
  <input type="button" class="buttons" value="+">
</p>
<p>
  <input type="button" class="buttons" value="0">
  <input type="button" class="esit" value="=" style="width:50px" onclick='esittir()'>
  <input type="button" class="buttons" value="/">

</p>

There is no error. But I am sure, .each() function should not be like this. @RaxWeber — Emin Çiftçi
– Emin Çiftçi, Commented Nov 18, 2016 at 7:50
Your each loop not taking the buttonArray to loop. Change it like this; $.each(buttonArray ,function(index, value) And you should change the other codes according to this. — Qsprec
– Qsprec, Commented Nov 18, 2016 at 7:53
It will be your first element in the array. Just check the @OriDrori 's answer. — Qsprec
– Qsprec, Commented Nov 18, 2016 at 7:59

Ori Drori · Accepted Answer · 2016-11-18 07:57:36Z

6

$.each 1st parameter is the array to iterate, the 2nd is the callback:

jQuery.each( array, callback )

The callback returns the iterated item as the 2nd param:

callback

Type: Function( Integer indexInArray, Object value ) The function that will be executed on every object.

In addition this in $.each() is the value of the item, you can't append to it.

You need to iterate the outer array, create a <p> element an append him to the container. Then iterate the sub arrays, create <input> (or just a <button> element), and append them to their <p> container:

var buttonArray = [
  [{
      type: 'button',
      className: 'sil',
      value: 'C'
    }, {
      type: 'button',
      className: 'hepsiniSil',
      value: 'AC'
    },

  ],
  [{
    type: 'button',
    className: 'buttons',
    value: '7'
  }, {
    type: 'button',
    className: 'buttons',
    value: '8'
  }, {
    type: 'button',
    className: 'buttons',
    value: '9'
  }, {
    type: 'button',
    className: 'buttons',
    value: '*'
  }],
  [{
    type: 'button',
    className: 'buttons',
    value: '4'
  }, {
    type: 'button',
    className: 'buttons',
    value: '5'
  }, {
    type: 'button',
    className: 'buttons',
    value: '6'
  }, {
    type: 'button',
    className: 'buttons',
    value: '-'
  }],
  [{
    type: 'button',
    className: 'buttons',
    value: '1'
  }, {
    type: 'button',
    className: 'buttons',
    value: '2'
  }, {
    type: 'button',
    className: 'buttons',
    value: '3'
  }, {
    type: 'button',
    className: 'buttons',
    value: '+'
  }],
  [{
    type: 'button',
    className: 'buttons',
    value: '0'
  }, {
    type: 'button',
    className: 'esit',
    value: '=',
    click: 'esittir'
  }, {
    type: 'button',
    className: 'buttons',
    value: '/'
  }]

];


var $calculator = $('#calculator');

$.each(buttonArray, function(index, buttons) {
  var $p = $('<p>').appendTo($calculator);

  $.each(buttons, function(subIndex, button) {
    $('<input>')
      .addClass(button.className)
      .prop('type', button.type)
      .val(button.value)
      .appendTo($p)
  });
});

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>

<div id="calculator"></div>

answered Nov 18, 2016 at 7:57

Ori Drori

196k32 gold badges243 silver badges233 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Emin Çiftçi Over a year ago

Thank you sir, it worked. One more question how can I handle the width ?. Some of buttons have width property.

arhak Over a year ago

similar to the handling of className, just set up a property before hand, and the process it: .width(button.myWidth)

Ori Drori Over a year ago

You're welcome :) You can a add a relevant class with the width to each button, or add a width property to the array, and set it to each button using .width(button.width).

Collectives™ on Stack Overflow

Javascript nested .each() function

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related