javascript array not working

Question

this is my html strcture

<div class="parent">
    <input class="child1" value="1">
    <input class="child2" value="2">
    <input class="child3" value="3">

</div>

i need to make a javascript array

combined_array={child1:"1", child2:"2", child3:"3"};

for this i write the following code . But it is not correct . Please help to find out error

$('.parent').children('input').each(function () {
                              var c_class=$(this).attr("class");
                              var c_value=$(this).val();
                              var combined_array={c_class:c_value};
                          });

                       alert(combined_array);

What is your result?

henrybbosa
– henrybbosa

2016-11-19 09:40:05 +00:00
Commented Nov 19, 2016 at 9:40 — henrybbosa
– henrybbosa, Commented Nov 19, 2016 at 9:40
That's an object and not an array

Andreas
– Andreas

2016-11-19 09:42:01 +00:00
Commented Nov 19, 2016 at 9:42 — Andreas
– Andreas, Commented Nov 19, 2016 at 9:42

Pranav C Balan · Accepted Answer · 2016-11-19 09:50:13Z

3

You are re-initializing the combined_array variable on each iteration so the result would be an object containing single property.

Instead initialize object outside and define property within the each() method callback.

var combined = {};
$('.parent').children('input').each(function() {
  var c_class = $(this).attr("class");
  var c_value = $(this).val();
  combined[c_class] = c_value;
});

console.log(combined);

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
<div class="parent">
  <input class="child1" value="1">
  <input class="child2" value="2">
  <input class="child3" value="3">

</div>

edited Nov 19, 2016 at 9:50

answered Nov 19, 2016 at 9:40

Pranav C Balan

115k25 gold badges172 silver badges195 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

sujit kinage · Accepted Answer · 2016-11-19 10:14:52Z

0

var combined_array={};
$('.parent').children('input').each(function () {
       combined_array[$(this).attr("class")]=$(this).val();
});
console.log(combined_array);
//alert(combined_array);

<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.1/jquery.min.js"></script>
<div class="parent">
    <input class="child1" value="1">
    <input class="child2" value="2">
    <input class="child3" value="3">
</div>

answered Nov 19, 2016 at 10:14

sujit kinage

274 bronze badges

Collectives™ on Stack Overflow

javascript array not working

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related