How can I allow multiple error rendering messages in rails api response

Question

I am trying to render error messages if any of the condition fails. How can I pass error messages related to failed conditions

But it gives me AbstractController::DoubleRenderError error

def create
    if @current_wbp_user && params[:user_id] && params[:note_id] && params[:comment] && params[:hashtag]
      user = User.find_by(id: params[:user_id])
      if user.present?
        if user.access_code != @current_wbp_user.access_code
          render json: {errors: "User not associated with this wbp user"}, status: :unprocessable_entity
        end
        note = Note.find_by(id: params[:note_id])
        if note.present?
          if note.user_id != user.id
            render json: {errors: "Invalid note for this user"}, status: :unprocessable_entity
          end
        else
          render json: {errors: "Note not found"}, status: :unprocessable_entity
        end
      else
        render json: {errors: "User not found"}, status: :unprocessable_entity
      end
      @comment = @current_wbp_user.wbp_user_comments.build(wbp_user_comments_params)
      if @comment.save
        render json: {success: true}, status: :ok
      else
        render json: {errors: "Comment could not be created"}, status: :unprocessable_entity
      end
    else
      render json: {errors: "Insufficient Information"}, status: :unprocessable_entity
    end
  end

Thanh · Accepted Answer · 2016-11-29 08:38:24Z

2

You need to add and return to every render in this block

if user.present?
...
end

to exit function. Example:

render json: {errors: "User not associated with this wbp user"}, status: :unprocessable_entity and return

edited Nov 29, 2016 at 8:38

answered Nov 29, 2016 at 8:07

Thanh

8,6445 gold badges37 silver badges59 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jagdeep Singh Over a year ago

Except the last one. That is optional.

Vishal G · Accepted Answer · 2016-11-29 08:19:47Z

0

No duplicate status codes and some refactoring, you can do some of validations in filters in this way your methods will look skinny and good

def create
    sucess = false
    if @current_wbp_user && [:user_id, :note_id, :comment, :hashtag].all? {|s| params.key? s}
      user = User.find_by(id: params[:user_id])
      if user.present?
        if user.access_code != @current_wbp_user.access_code
          message = "User not associated with this wbp user"
        end
        note = Note.find_by(id: params[:note_id])
        if note.present?
          if note.user_id != user.id
            message = "Invalid note for this user"
          end
        else
          message = "Note not found"
        end
      else
        message = "User not found"
      end
      @comment = @current_wbp_user.wbp_user_comments.build(wbp_user_comments_params)
      if @comment.save
        sucess = true
      else
        message = "Comment could not be created"
      end
    else
      message = "Insufficient Information"
    end

    if sucess
      render json: {success: true}, status: :ok
    else
      render json: {errors: message}, status: :unprocessable_entity
    end
  end

answered Nov 29, 2016 at 8:19

Vishal G

1,54111 silver badges34 bronze badges

2 Comments

Vishal G Over a year ago

@prem status code are not duplicated in this answer

Alif Jamaluddin Over a year ago

This way is more cleaner.

Duyet Nguyen · Accepted Answer · 2016-11-29 10:07:14Z

def create
  error_msgs = Array.new
  if @current_wbp_user && params[:user_id].present? && params[:note_id].present?
    user = User.find_by(id: params[:user_id])
    if user.present?
      if user.access_code != @current_wbp_user.access_code
        error_msgs << "User not associated with this wbp user"
      end
      note = Note.find_by(id: params[:note_id])
      if note.present?
        if note.user_id != user.id
          error_msgs << "Invalid note for this user"
        end
      else
        error_msgs << "Note not found"
      end
    else
      error_msgs << "User not found"
    end

    if params[:comment].present? && params[:hashtag].present?
      @comment = @current_wbp_user.wbp_user_comments.build(wbp_user_comments_params)
      if @comment.save
        render json: {success: true}, status: :ok
        return
      else
        error_msgs << "Comment could not be created"
      end
    end
  else
    error_msgs << "Insufficient Information"
  end

  if error_msgs.present?
    render json: {errors: error_msgs}, status: :unprocessable_entity
  end
end

Collectives™ on Stack Overflow

How can I allow multiple error rendering messages in rails api response

3 Answers 3

1 Comment

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related