Trying to pass multiple parameters from php to javascript

Question

Heres my current code in php with one parameter which works

 <?php
  $sid = "012";
  echo '<input type="button" value="Submit" onclick="changeConfirmed('.$sid.')">';

?>

Now im trying to pass two parameters or more, but cant seem to get it to work, here is my attempt:

 <?php
  $name="abc
  $sid = "012";
  echo '<input type="button" value="Submit" onclick="changeConfirmed('.$sid.','.$name.')">';

?>

"cant seem to get it to work" is an insufficient problem description. Please clearly state what you would expect and what the result is instead. Edit the question to include the changeConfirmed function and possibly any error that is triggered. — ImportanceOfBeingErnest
– ImportanceOfBeingErnest, Commented Nov 29, 2016 at 22:03

DiddleDot · Accepted Answer · 2016-11-29 21:47:42Z

3

You need quotes around the parameters or javascript treats them like variables instead of strings.

echo '<input type="button" value="Submit" onclick="changeConfirmed(\''.$sid.'\',\''.$name.'\')">';

answered Nov 29, 2016 at 21:47

DiddleDot

7435 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Matthew Peltzer · Accepted Answer · 2016-11-29 21:49:14Z

2

If one of your JavaScript function parameters is a string, you'll have to correctly enclose it in quotes:

<?php
  $name="abc";
  $sid = "012";
  echo '<input type="button" value="Submit" onclick="changeConfirmed('.$sid.',\''.$name.'\')">';
?>

You get away with $sid not enclosed in quotes because it looks like a number.

answered Nov 29, 2016 at 21:49

Matthew Peltzer

1382 silver badges10 bronze badges