ReferenceError after loading a script using $.getScript()

Question

I have JS file hosted at https://cdn.rawgit.com/DarkPotatoKing/darkpotatoking.github.io/master/latest_version.js

When I run the following script on the browser console

jQuery.getScript("https://cdn.rawgit.com/DarkPotatoKing/darkpotatoking.github.io/master/latest_version.js")
	.done(function() {
		alert("done");
	})
	.fail(function() {
		alert("fail");
});

I get a popup that says "done", but when I run

version.number()

the following error message is returned

ReferenceError: version is not define

Why is "version" not defined if the script is supposedly loaded properly?

from latest_version.js: SyntaxError: missing } after property list — jeff carey
– jeff carey, Commented Dec 6, 2016 at 15:06

ntahoang · Accepted Answer · 2016-12-06 15:07:16Z

1

Your script at has a syntax error, so it cannot be parsed. Correct your script, and version.number() will come:

var version = {
    number: function() { return "1.1"; }; <==Syntax error here
}

Of course you must call version.number() from inside .done(function () {...})

answered Dec 6, 2016 at 15:07

ntahoang

4495 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2020-06-20 09:12:55Z

0

EDIT

Ok i solved it for you, you need to change that uploaded file to this:

var version = {
    number: function() { return "1.1"; }
}

you have a ; to much in that code.

And this is your new javscript/jquery code:

$.getScript( "https://cdn.rawgit.com/DarkPotatoKing/darkpotatoking.github.io/master/latest_version.js" )
.done(function( script, textStatus ) {
    console.log(version.number);
})
.fail(function( jqxhr, settings, exception ) {
    console.log("nope");
});

OLD

This is because your code is not in sync.

if you run version.number() inside the .done it must work.

edited Jun 20, 2020 at 9:12

CommunityBot

11 silver badge

answered Dec 6, 2016 at 15:00

UNTITLED.PNG

539 bronze badges

2 Comments

DarkPotatoKing Over a year ago

I replaced 'alert("done")' with 'vs = version.number()', but when I access vs after that it says vs is undefined. What can I do to access the string returned by version.number() outside the getScript() call?

UNTITLED.PNG Over a year ago

@DarkPotatoKing you need to stay inside the .done. Why? Little explanation: you request a file, that needs to download so javascript does not wait for that shit and runs the other code and when the file that was requested is downloaded. It wil run the .done code. So when you are outside the .done and ask for vs = version.number() it will say its undefined because the file is not loaded yet.

Collectives™ on Stack Overflow

ReferenceError after loading a script using $.getScript()

2 Answers 2

Comments

EDIT

OLD

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

EDIT

OLD

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related