Json, linq and SQL multiple row inserts same row

Question

Iam trying to get a JSON array into a MSSQL table using linq. I almost got it to work but with the current code, it inserts the first row for the duration of the for at the list part. the table looks like this after the insert. This is my code:

List<insertmultiapiwhitelist> thelist = new List<insertmultiapiwhitelist>();
        string json = "[{'naam':'Default Web Site','webid':1,'verbruik':0,'datum':'2016-12-05 00:00:00'}]";
//json above has 150 items, purged to keep it clean.
        dynamic jsondata = JsonConvert.DeserializeObject(json);

        foreach (var jsonitem in jsondata)
        {
            thelist.Add(new insertmultiapiwhitelist()
            {
                naam = jsondata[0].naam,
                webid = jsondata[1].webid,
                verbruik = jsondata[2].verbruik,
                datum = jsondata[3].datum
            });
        }

        foreach(var listgebruik in thelist)
        {
            webfarm_data dbtoevoegingen = new webfarm_data();
            dbtoevoegingen.naam = listgebruik.naam;
            dbtoevoegingen.webid = listgebruik.webid;
            dbtoevoegingen.verbruik = listgebruik.verbruik;
            dbtoevoegingen.datum = DateTime.Parse(listgebruik.datum);
            DeDB.webfarm_data.Add(dbtoevoegingen);
        }

        var updateantwoord = new insertmultiapiwhitelist { antwoord = "Niets ontvangen" };
        try
        {
            DeDB.SaveChanges();
            updateantwoord = new insertmultiapiwhitelist { antwoord = "Insert voltooid" };
        }
        catch (Exception e)
        {
            var foutmelding = e.ToString();
            updateantwoord = new insertmultiapiwhitelist { antwoord = foutmelding };
        }
        return View(updateantwoord);

msokrates · Accepted Answer · 2016-12-06 15:19:48Z

1

I think you first foreach should look like this:

 foreach (var jsonitem in jsondata)
    {
        thelist.Add(new insertmultiapiwhitelist()
        {
            naam = jsonitem.naam,
            webid = jsonitem.webid,
            verbruik = jsonitem.verbruik,
            datum = jsonitem.datum
        });
    }

answered Dec 6, 2016 at 15:19

msokrates

18810 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Frostopal Over a year ago

That was it! I choose the wrong definition for the foreach.

holland · Accepted Answer · 2016-12-06 15:20:10Z

0

So if I understand your question correctly you mean that it inserts the first row instead of each individual one? I think your mistake is here:

    foreach (var jsonitem in jsondata)
    {
        thelist.Add(new insertmultiapiwhitelist()
        {
            naam = jsondata[0].naam,
            webid = jsondata[1].webid,
            verbruik = jsondata[2].verbruik,
            datum = jsondata[3].datum
        });
    }

Shouldn't it be this:

    foreach (var jsonitem in jsondata)
    {
        thelist.Add(new insertmultiapiwhitelist()
        {
            naam = jsonitem.naam,
            webid = jsonitem.webid,
            verbruik = jsonitem.verbruik,
            datum = jsonitem.datum
        });
    }

You are basically saying "For each item in my list, insert the 0th element's name and its 1th element webid" which is exactly the same each loop. You should use jsonitem instead of jsondata ;-)

answered Dec 6, 2016 at 15:20

holland

2,2025 gold badges33 silver badges59 bronze badges

3 Comments

holland Over a year ago

Darn it! 1 second too late after @msokrates answer

Frostopal Over a year ago

Yea I see my mistake now. I"derped" alot looking where It went wrong. I also removed the [] part from the jsonitem.x. Thanks!

holland Over a year ago

Debugging is your best friend for solving these problems ;-) In case you're not familiar with debugging, you should absolutely look it up! It will save you tons of time.

Collectives™ on Stack Overflow

Json, linq and SQL multiple row inserts same row

2 Answers 2

1 Comment

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related