Typescript function from another class

Question

I am pretty new to typescript, but now I have a problem. I've written a function in Typescript out of every class

function someFunction(){
}

And now I wanted to call the function from another TS file and i declared it as follows:

declare function someFunction(): void;

But this won't work in the browser console I get the error

Uncaught ReferenceError: someFunction() is not defined

File one looks like:

export class SomeClass{
}

export function someFunction(){
}

File two :

///<reference path="File1.ts" />
export class SomeOtherClass{
 someFunction();
}

In this function is an algorithm which I wanna call from another class too. (Controller) So that I dont have to duplicate the code — Markus G.
– Markus G., Commented Dec 15, 2016 at 13:42

Bizhan · Accepted Answer · 2016-12-18 14:13:05Z

5

You do not need to declare the function, you can reference the file that has it and then the compiler will know it.
For example:

// file1.ts

function someFunction(): string {
    ...
}

Use it:

// file2.ts

/// <reference path="file1.ts" />

let mystr = someFunction();

The error you are getting is a runtime error because you don't include file1.js:

<script src="file1.js" />

Edit

The code you added to your question compiles for me with two changes:

(1) removed exports:

// file1.ts

class SomeClass {}

function someFunction() {}

(2) added a class method:

// file2.ts

/// <reference path="file1.ts" />

class SomeOtherClass {
    fn() {
        someFunction();
    }
}

Edit by Original Poster: Second Solution (worked for me)

// file1.ts

export function someFunction(){
    ...
}

Use it:

// file2.ts

import myFunc = require('./file1');

myFunc.someFunction();

edited Dec 18, 2016 at 14:13

Bizhan

17.2k11 gold badges67 silver badges108 bronze badges

answered Dec 15, 2016 at 13:22

Nitzan Tomer

166k51 gold badges330 silver badges307 bronze badges

Sign up to request clarification or add additional context in comments.

13 Comments

Markus G. Over a year ago

The compiler doesn't recognize this function when I set a reference to the file...

Nitzan Tomer Over a year ago

Right, add export. I fixed my answer.

Markus G. Over a year ago

In file1.ts I added what you said export function etc. but It still won't load, i get a compiler error again

Nitzan Tomer Over a year ago

I checked it myself, and it works without the export that I've added (now removed). For me it works and I get no compilation errors. What are you getting?

Markus G. Over a year ago

I think I should say I work with VS Code and Gulp. The built in INtelliSense says "Cannot find name someFunction" #update start post edit

|

Pian0_M4n · Accepted Answer · 2016-12-15 13:23:34Z

-1

I don't get exactly what you are trying to do, but in typescript defining a function is done like this:

public someFunction(): void {}

You can replace public with private or protected according to what you need, or even remove it

Calling from the browser should be done by the framework you use using events (click) etc

answered Dec 15, 2016 at 13:23

Pian0_M4n

2,56836 silver badges35 bronze badges

1 Comment

Nitzan Tomer Over a year ago

No, that's not a class method, it's a function outside of a class.

Collectives™ on Stack Overflow

Typescript function from another class

2 Answers 2

Edit

13 Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Edit

13 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related