Problems with array conversion in C

Question

I'm having problems with a little beginners Programm in C, specifically with the Array output.

#include <stdio.h>
#include <stdlib.h>

#define X 10
#define Y 10

void init_world(char (*)[Y][X]);
void next_gen(char (*)[Y][X], char (*)[Y][X]);
void put_world(char (*matrix)[Y][X]);

int main(void)
{
    int x=0;
    char welt1[X][Y];
    char welt2[X][Y];
    init_world(welt1);
    put_world(welt1);
    do
    {
        next_gen(welt1,welt2);
        put_world(welt1);
        x++;

    }while((welt2!=welt1)and (x<10));
    getchar();
    return 0;
}

void init_world(char (*welt)[Y][X])
{
    ...
}


void next_gen(char (*zelle)[Y][X], char (*neu)[Y][X])
{
    ...
}

void put_world(char (*matrix)[Y][X])
{
    int y, x;
    for(y=0; y<X; y++)
        for(x=0; x<Y; x++)
            if(matrix[y][x] != 0)
                printf("%c",'*');
            else printf("%c",' ');
        printf("\n");
    printf("\n--------------\n");
}

The last function should print the array elements. This should happen in a maxtrix of '*' or ' ' but it keeps printing these just in lines

******* *****   *************** ***     *** *** *** ***  
*********************** *** *** *** *   *

--------------

(welt2!=welt1) always true. Also char welt1[X][Y]; char welt2[X][Y]; --> char welt1[Y][X]; char welt2[Y][X]; — BLUEPIXY
– BLUEPIXY, Commented Dec 20, 2016 at 13:00
If you want your program to print the array, you have to code it to do so. Right now all the code says is print an '*' or a space. — Herb
– Herb, Commented Dec 20, 2016 at 13:02
init_world, next_gen and put_world are arguments type mismatch. E.g char (*matrix)[Y][X] --> char (*matrix)[X] — BLUEPIXY
– BLUEPIXY, Commented Dec 20, 2016 at 13:05

instance · Accepted Answer · 2016-12-20 12:59:20Z

1

void put_world(char (*matrix)[Y][X])
{
    int y, x;
    for(y=0; y<X; y++)
    {
        for(x=0; x<Y; x++)
            if(matrix[y][x] != 0)
                printf("%c",'*');
            else printf("%c",' ');
        printf("\n");    //Out of scope of first for loop previously (keep it in).
    }
    printf("\n--------------\n");
}

answered Dec 20, 2016 at 12:59

instance

1,38415 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jabberwocky Over a year ago

The line else printf("%c",' '); is very poorly indented.

Seb33300 · Accepted Answer · 2016-12-20 13:04:22Z

1

Your printf("\n") is not part of your for loop.

    void put_world(char (*matrix)[Y][X])
    {
        int y, x;
        for(y=0; y<X; y++)
        {
            for(x=0; x<Y; x++)
                if(matrix[y][x] != 0)
                    printf("%c",'*');
                else printf("%c",' ');
            printf("\n");
        }
        printf("\n--------------\n");
    }

Should do it.

edited Dec 20, 2016 at 13:04

Seb33300

7,5662 gold badges44 silver badges61 bronze badges

answered Dec 20, 2016 at 12:59

Zinki

4464 silver badges10 bronze badges

4 Comments

Jabberwocky Over a year ago

The line else printf("%c",' '); is very poorly indented.

Zinki Over a year ago

@MichaelWalz The indentation is correct. As the else is part of the if-statement, it is part of the inner for loop and thus correctly indented as it stands (on level with the if).

Jabberwocky Over a year ago

@Zinki what I meant is that printf("%c",' '); should be on the line following the else at the same indentation level as printf("%c",'*');. Somewhat like this: if(matrix[y][x] != 0)\n printf("%c",'*');\nelse\n printf("%c",' ');\n.

Zinki Over a year ago

@MichaelWalz Ah I see, yes, that would add to the code readability, but considering the question I wanted to make the minimum number of changes to OPs code to make it work. If we're talking aesthetics and readability, there are a number of further changes I'd make.

Collectives™ on Stack Overflow

Problems with array conversion in C

2 Answers 2

1 Comment

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related