php find multiple occurence of string in string

Question

I have a function which basically retrieves the product id in a description.

private function scanForProductIdInDescription($string, $start, $end) {
        $startpos = strpos($string, $start) + strlen($start);
        if (strpos($string, $start) !== false) {
            $endpos = strpos($string, $end, $startpos);
            if (strpos($string, $end, $startpos) !== false) {
                return substr($string, $startpos, $endpos - $startpos);
            }
        }
    }

i use it as follows:

$from = "{PID =";
 $end = "}";
$description = 'some text {PID =340}  {PID =357}';
 $product_id = $this->scanForProductIdInDescription($description, $from, $end);

at the moment, it only gets the first occurence in the string. I need to find all occurences in the string. The result should be: $product_id = 340,357;

thanks

If you do not wish to use regex then have a look at this question — kscherrer
– kscherrer, Commented Dec 23, 2016 at 8:50
@PhpDev should be: $product_id = 340,357 - the result is a string or an array? — RomanPerekhrest
– RomanPerekhrest, Commented Dec 23, 2016 at 8:50

Tom · Accepted Answer · 2016-12-23 08:58:03Z

3

Using a regular expression instead of strpos() is going to be you best bet. I've quickly put the following together which works with your example;

\{PID\s=([0-9]*)\}

You can see a working version here

Use of this in PHP would look like;

$re = '/\{PID\s=([0-9]*)\}/';
$str = 'some text {PID =340}  {PID =357}';

preg_match_all($re, $str, $matches);

// Print the entire match result
print_r($matches);

Edit: Edited to return only the actual ID in the matched string. IMO - this is a better solution than the other 2 answers posted as it returns ID's of any length, and only returns ID's matched in the format you've provided.

I've also updated my working example.

edited Dec 23, 2016 at 8:58

answered Dec 23, 2016 at 8:49

Tom

4,3128 gold badges35 silver badges49 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Blaatpraat Over a year ago

I would put parentheses around [0-9]* so you can capture the values immediately :)

Mihai Matei · Accepted Answer · 2016-12-23 08:52:15Z

1

You can use preg_match_all:

$description = 'some text {PID =340}  {PID =357}';

preg_match_all('/=([0-9]+)\}/', $description, $matches);

var_dump($matches);

The result is:

array(2) {
  [0]=>
  array(2) {
    [0]=>
    string(5) "=340}"
    [1]=>
    string(5) "=357}"
  }
  [1]=>
  array(2) {
    [0]=>
    string(3) "340"
    [1]=>
    string(3) "357"
  }
}

answered Dec 23, 2016 at 8:52

Mihai Matei

24.3k5 gold badges34 silver badges50 bronze badges

2 Comments

Rotimi Over a year ago

at matei how do i get the result to display 340,357

Rotimi Over a year ago

the result displays {PID = 340},{PID =357}

RomanPerekhrest · Accepted Answer · 2016-12-23 09:02:43Z

1

To get the needed result(only PID numbers) - use the following approach:

$description = 'some text {PID =340}  {PID =357}';
preg_match_all("/(?<=\{PID =)\d+(?=\})/", $description, $matches);
$result = $matches[0];

print_r($result);

The output:

Array
(
    [0] => 340
    [1] => 357
)

answered Dec 23, 2016 at 9:02

RomanPerekhrest

93.1k4 gold badges75 silver badges112 bronze badges

1 Comment

Rotimi Over a year ago

worked like a charm! Thank you very much @roman. unforunately i cannot vote because i have a low reputation. Thanks again!

atoms · Accepted Answer · 2016-12-23 09:04:01Z

1

You could use preg_match_all as followed:

<?php 


    // $sPattern = '^{PID\s=\d{3}}^';

    // by using a capture group "(" + ")" to enclose the number (\d), you can output just the numbers
    $sPattern = '{PID\s=(\d{3})}';

    $aOutput = array();
    $sString = 'some text {PID =340}  {PID =357}';

    preg_match_all($sPattern, $sString, $aOutput);

    // implode the first capture group to a string
    $aOutput = implode(",", $aOutput[1]);

    echo "<pre>";
    var_dump($aOutput);
?>

This will output:

string(7) "340,357"

edited Dec 23, 2016 at 9:04

answered Dec 23, 2016 at 8:55

atoms

3,1032 gold badges25 silver badges46 bronze badges

2 Comments

Rotimi Over a year ago

cool @atoms. how do i get the result to just print out 340,357

Rotimi Over a year ago

great. exactly. Thanks @atoms

mickmackusa · Accepted Answer · 2018-08-06 05:40:34Z

1

You can completely avoid the capture group, by using \K to restart the fullstring match before your desired numeric substrings.

Code: (Demo: https://3v4l.org/WalUc )

$description = 'some text {PID =340}  {PID =357}';
echo implode(',', preg_match_all('~\{PID =\K\d+~', $description, $out) ? $out[0] : []);

Output:

340,357

The benefits to this technique are:

Fewer steps for the regex engine to make.
No unnecessary bloat in the matches array ($out).

answered Aug 6, 2018 at 5:40

mickmackusa♦

49.2k13 gold badges98 silver badges165 bronze badges

1 Comment

Rotimi Over a year ago

spot on. Thank you!

Collectives™ on Stack Overflow

php find multiple occurence of string in string

5 Answers 5

1 Comment

2 Comments

1 Comment

2 Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

2 Comments

1 Comment

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related