php foreach looping off value from mysql row

Question

I am looping through rows of mysql data as array's.

All the data goes into the labels fine as single values, yet when the edit button is used it does "updatecompany.php?id=1&id=2 when it should just be ?id=1 or ?id=2.

What am I doing wrong for that single field? Why is it pulling both values from the rows and not just one like the rest of the echo's.

  <?php
    $details = \Ar\login::getCompanys();
    foreach($details as $value){
      echo "<div class='container'><div class='well'>";
      echo "ID: " . $value['id'];
      echo "<br>";
      echo "Company: " . $value['name'];
      echo "<br>";
      echo "Logo: " . $value['logo'];
      echo "<br>";
      echo "Url: " . $value['site'];
      echo "<br>";
      echo "EST: " . $value['est'];
      echo "<br>";
      echo "Info: " . $value['info'];
      echo "<br><br>";
      echo "<form action='updatecompany.php' method='get'><input type='hidden' name='id' value='". $value['id'] ."'/><button type='submit' class='btn btn-lg btn-primary'>Edit</button>";
      echo "</div></div>";
      echo "<br>";
    }
    //print_r($details);
  ?>

You never close your <form> so you have one huge form with child forms. — chris85
– chris85, Commented Jan 3, 2017 at 21:00

chris85 · Accepted Answer · 2017-01-03 22:32:13Z

1

You never close your form so you are making multiple forms. You also don't need multiple echos either. Something like:

echo "<div class='container'><div class='well'>
     ID: " . $value['id'] .
     "<br>
     Company: " . $value['name'] . 
     "<br>
     Logo: " . $value['logo'] . 
     "<br>
     Url: " . $value['site'] .
     "<br>
     EST: " . $value['est'] .
     "<br>
     Info: " . $value['info'] .
     "<br><br>
     <form action='updatecompany.php' method='get'>
           <input type='hidden' name='id' value='". $value['id'] ."'/>
           <button type='submit' class='btn btn-lg btn-primary'>Edit</button>
    </form> /* <-- guess */       
    </div>
    </div>
    <br>";

Should resolve the issue (the closing form location is a guess).

edited Jan 3, 2017 at 22:32

answered Jan 3, 2017 at 22:15

chris85

23.9k7 gold badges36 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

ajankuv · Accepted Answer · 2017-01-03 21:03:47Z

0

</form>

Never closed the form out causing it to go nuts.

answered Jan 3, 2017 at 21:03

ajankuv

4973 silver badges22 bronze badges

Comments

chris85 · Accepted Answer · 2017-01-03 22:16:23Z

0

you should close the <form> tag in your code. So your form line should look like:

echo "<form action='updatecompany.php' method='get'><input type='hidden' name='id' value='". $value['id'] ."'/><button type='submit' class='btn btn-lg btn-primary'>Edit</button></form>";

Then you'll get the correct results.

edited Jan 3, 2017 at 22:16

chris85

23.9k7 gold badges36 silver badges51 bronze badges

answered Jan 3, 2017 at 21:10

Lukas

2011 silver badge4 bronze badges

Collectives™ on Stack Overflow

php foreach looping off value from mysql row

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related