Ruby ajax js view returns encoded html instead of valid html

Question

I've got a javascript view (add_to_garden.js.erb) that responds to an ajax action and tries to render a flash message telling the user about the updated info. This works:

// Flash message to user
<% flash.each do |key, message| %>
  $("#flash").html("<%= j(render( partial: "shared/flash_message", locals: {key: key, message: message } )) %>");
<% end %>

Of course as it's written above, the html for each flash message will replace the previous one so only the last message will be shown to the user.

This does render all the messages...

// Flash message to user
<% flash[:error] = "AAAAHHHHHH... an error" %>
<% flash[:info] = "Just so you know, that was an error." %>
<% flash.each do |key, message| %>
  <% (@alerts ||= '') << render( partial: "shared/flash_message", locals: {key: key, message: message } ) %>
<% end %>
$("#flash").html("<%= j(@alerts) %>");
flashMessageSetTimeout();

...but the messages in @alerts are htmlencoded by the time they get to the browser:

How to fix?

Surya · Accepted Answer · 2017-01-05 13:02:17Z

1

Use append:

<% flash.each do |key, message| %>
  $("#flash").append("<%= j(render( partial: "shared/flash_message", locals: {key: key, message: message } )) %>");
<% end %>

append inserts string to designated dom element.

However, if you still want to go ahead with your current approach with html() then use html_safe method:

$("#flash").html("<%= j(@alerts.html_safe) %>");

answered Jan 5, 2017 at 13:02

Surya

16k3 gold badges55 silver badges77 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

doub1ejack Over a year ago

Oh yeah, that's nicer.

Kielstra · Accepted Answer · 2017-01-05 13:00:50Z

0

You want you use html_escape() or simply h() in rails. If you apply this to @alerts it will show the html that you want to display.

answered Jan 5, 2017 at 13:00

Kielstra

5351 gold badge3 silver badges15 bronze badges

1 Comment

doub1ejack Over a year ago

Ok. I just used raw but I see that they are actually the same thing.

Collectives™ on Stack Overflow

Ruby ajax js view returns encoded html instead of valid html

2 Answers 2

1 Comment

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related