Not able to call function on button click in Javascript html

Question

I have below code i need to call function on click of button. but it is not atall calling those function. What is wrong in below code.

<!DOCTYPE html>
<html>
<body>

<input type="button" value="Copy Parent Text" id="CopyParent"  onclick="getRate("SEK", "USD")">
<input type="button" value="Copy Child Text" id="CopyChild"  onclick="getRate("USD", "SEK")">


<script type="text/javascript">

  function getRate(from, to) {
  alert("1");
    var script = document.createElement('script');
    script.setAttribute('src', "http://query.yahooapis.com/v1/public/yql?q=select%20rate%2Cname%20from%20csv%20where%20url%3D'http%3A%2F%2Fdownload.finance.yahoo.com%2Fd%2Fquotes%3Fs%3D"+from+to+"%253DX%26f%3Dl1n'%20and%20columns%3D'rate%2Cname'&format=json&callback=parseExchangeRate");
    document.body.appendChild(script);
  }

  function parseExchangeRate(data) {
    var name = data.query.results.row.name;
    var rate = parseFloat(data.query.results.row.rate, 10);
    alert("Exchange rate " + name + " is " + rate);
  }

</script>

</body>
</html>

Please help me on this.

ADyson · Accepted Answer · 2017-01-06 11:53:07Z

1

You have a syntax error because you're enclosing double quotes within double quotes. If you look in the browser's console when you click the button it will show you the error.

You can change the HTML like this to resolve it:

<input type="button" value="Copy Parent Text" id="CopyParent"  onclick="getRate('SEK', 'USD')">
<input type="button" value="Copy Child Text" id="CopyChild"  onclick="getRate('USD', 'SEK')">

answered Jan 6, 2017 at 11:53

ADyson

62.9k16 gold badges85 silver badges99 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

kind user Over a year ago

These guys are called rep diggers. Sitting on SO whole day and just camping for trivial questions, like how to declare variable in JS. Sad, but true.

Nishant Saini · Accepted Answer · 2017-01-06 11:54:41Z

0

simple mistake "getRate('SEK', 'USD')" and "getRate('USD', 'SEK')"

<!DOCTYPE html>
<html>
<body>

<input type="button" value="Copy Parent Text" id="CopyParent"  onclick="getRate('SEK', 'USD')">
<input type="button" value="Copy Child Text" id="CopyChild"  onclick="getRate('USD', 'SEK')">


<script type="text/javascript">

  function getRate(from, to) {
  alert("1");
    var script = document.createElement('script');
    script.setAttribute('src', "http://query.yahooapis.com/v1/public/yql?q=select%20rate%2Cname%20from%20csv%20where%20url%3D'http%3A%2F%2Fdownload.finance.yahoo.com%2Fd%2Fquotes%3Fs%3D"+from+to+"%253DX%26f%3Dl1n'%20and%20columns%3D'rate%2Cname'&format=json&callback=parseExchangeRate");
    document.body.appendChild(script);
  }

  function parseExchangeRate(data) {
    var name = data.query.results.row.name;
    var rate = parseFloat(data.query.results.row.rate, 10);
    alert("Exchange rate " + name + " is " + rate);
  }

</script>

</body>
</html>

edited Jan 6, 2017 at 11:54

answered Jan 6, 2017 at 11:52

Nishant Saini

4113 silver badges13 bronze badges

2 Comments

ADyson Over a year ago

how about pointing out what and where the error is, instead of just a big code dump, which includes parts of the code not even relevant to the error? OP would have to compare everything to see what's changed. It would take 10 seconds to add an explanation.

daisy Over a year ago

@Nishant Saini Thanks. I choose yuor answer because you were first one to answer this post.

Super User · Accepted Answer · 2017-01-06 11:52:03Z

0

You have add double quot inside double quote "getRate("USD", "SEK")". Just change you html like below:

<input type="button" value="Copy Parent Text" id="CopyParent"  onclick='getRate("SEK", "USD")'>
<input type="button" value="Copy Child Text" id="CopyChild"  onclick='getRate("USD", "SEK")'>

answered Jan 6, 2017 at 11:52

Super User

9,6623 gold badges34 silver badges48 bronze badges

Comments

abhi nagi · Accepted Answer · 2017-01-06 11:59:53Z

0

Check the documentation on using onclick function. U have to specify the single quotes for parameters if u are using onclick

<input type="button" value="Copy Parent Text" id="CopyParent"  onclick="getRate('SEK', 'USD')">
<input type="button" value="Copy Child Text" id="CopyChild"  onclick="getRate('USD', 'SEK')">

answered Jan 6, 2017 at 11:59

abhi nagi

193 bronze badges

Collectives™ on Stack Overflow

Not able to call function on button click in Javascript html

4 Answers 4

1 Comment

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related