MySQL Syntax Error Exception when executing Update query

Question

I'm getting the message

"MySQLSyntaxErrorExcetpion You have an error in your SQL syntax."

I'm following a tutorial online and I don't see what's anything different with my code and the code I'm following. Can anyone point out where I went wrong?

Let me know if additional information is needed.

btn_update.addActionListener(new ActionListener(){


            @Override
            public void actionPerformed(ActionEvent e) {

                try{
                    theQuery("update users set fname = '" + firstNameField.getText() + "', lname = '" + lastNameField.getText() +"', age=" + ageField.getText() + "where id = " + idField.getText());
                }
                catch(Exception ex)
                {
                    System.out.println(ex);
                    }

            }
        });

Mandatory comment: This code is wide open to SQL-injection attacks. Consider using a PreparedStatement instead. — Mureinik
– Mureinik, Commented Jan 6, 2017 at 20:50

Youcef LAIDANI · Accepted Answer · 2017-09-14 18:49:03Z

1

because you don't have spaces here:

age=" + ageField.getText() + "where id = " + idField.getText());

You need to change it to

age= " + ageField.getText() + " where id = " + idField.getText());

I advice to use PreparedStatement instead of the native way

edited Sep 14, 2017 at 18:49

answered Jan 6, 2017 at 20:53

Youcef LAIDANI

60.3k21 gold badges111 silver badges178 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Andy Over a year ago

I was so close! lol I'll try prepared statement next time thanks!

Bob · Accepted Answer · 2017-01-06 20:52:38Z

0

Add a space in front of " where id = ". That should work

answered Jan 6, 2017 at 20:52

Bob

842 silver badges9 bronze badges

Comments

Nouman Ahmad Khan · Accepted Answer · 2017-01-06 20:56:54Z

0

Use toString() function to convert values to string and then pass them to query, as follow:

firstNameField.getText().toString()

answered Jan 6, 2017 at 20:56

Nouman Ahmad Khan

232 silver badges10 bronze badges

Collectives™ on Stack Overflow

MySQL Syntax Error Exception when executing Update query

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related