Replace variable in class by anonymous function

Question

i have a class test that initiates a variable and register some anonymous functions. a function to display the variable testvar and another anonymous function to replace the variable with another variable. The problem is, wenn i call display the second time, the result is a variable but it should be another variable. I hope you understand the example and thank you very much.

class test {

    private $functions = array();
    private $testvar; 

    function __construct() {

        $this->testvar = "a variable";
        $this->functions['display'] = function($a) { return $this->display($a); };
        $this->functions['replace'] = function($options) { return $this->replace($options); };

    }

    private function display($a) {
        return $this->$a;
    }

    private function replace($options) {
        foreach($options as $a => $b) {
            $this->$a = $b;
        }
    }

    public function call_hook($function, $options) {
        return call_user_func($this->functions[$function], $options);
    }

}

$test = new test();

echo $test->call_hook("display","testvar");

$test->call_hook("replace",array("testvar","another variable"));

echo $test->call_hook("display","testvar");

why not use the functions display or replace as they are?

Ibu
– Ibu

2017-01-07 00:01:46 +00:00
Commented Jan 7, 2017 at 0:01 — Ibu
– Ibu, Commented Jan 7, 2017 at 0:01

MazzCris · Accepted Answer · 2017-01-06 23:55:33Z

1

As you are passing only one [variable_name, new_value] pair, I would just change the replace function to this:

private function replace($options) {
    $this->$options[0] = $options[1];
}

But, if you want to keep your code as it is, it will work if you replace this

$test->call_hook("replace",array("testvar", "another variable"));

with this

$test->call_hook("replace",array("testvar" => "another variable"));
                                          ^^^^

This will make sure that the foreach statement will match your parameters correctly, as you are parsing the values as key => value pairs

foreach($options as $a => $b) {
                    ^^^^^^^^
    $this->$a = $b;
}

edited Jan 6, 2017 at 23:55

answered Jan 6, 2017 at 23:44

MazzCris

1,8301 gold badge14 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Replace variable in class by anonymous function

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related