Password and Username using Python GUI

Question

This is a simple GUI program to check whether the user entered correct username and password. The problem is that even when inputting the correct username and password i.e admin and secret, it still outputs 'Invalid Login'

This is the code :

from tkinter import *
import tkinter.messagebox as box

def dialog1():
    box.showinfo('info','Correct Login')
def dialog2():
    box.showinfo('info','Invalid Login')

window = Tk()
window.title('Countries Generation')

frame = Frame(window)

Label1 = Label(window,text = 'Username:')
Label1.pack(padx=15,pady= 5)

entry1 = Entry(window,bd =5)
entry1.pack(padx=15, pady=5)

username = entry1.get()

Label2 = Label(window,text = 'Password: ')
Label2.pack(padx = 15,pady=6)

entry2 = Entry(window, bd=5)
entry2.pack(padx = 15,pady=7)

password = entry2.get()

if (username == 'admin' and  password == 'secret'):
    btn = Button(frame, text = 'Check Login',command = dialog1)
else:
    btn = Button(frame, text ='Check Login', command = dialog2)

btn.pack(side = RIGHT , padx =5)
frame.pack(padx=100,pady = 19)
window.mainloop()

stackoverflow.com/questions/16525582/… && stackoverflow.com/questions/28156719/… there are tons of examples out there to show you how to do it. — Lafexlos
– Lafexlos, Commented Jan 10, 2017 at 12:12
Any and all event fired checks should be done through a function. Your if statement is run once the script starts, move the check to a function which is called once the button is pressed instead. — Steven Summers
– Steven Summers, Commented Jan 10, 2017 at 12:15

Midhun Mohan · Accepted Answer · 2017-01-10 12:26:45Z

0

i think you should think about using a class instead of the raw code which you will be having a good control . Any way i just corrected your logic instead of checking it before button click get the values after button click and then run

after that your code looks something like this

from tkinter import *
import tkinter.messagebox as box

def dialog1():
    username=entry1.get()
    password = entry2.get()
    if (username == 'admin' and  password == 'secret'):
        box.showinfo('info','Correct Login')
    else:
        box.showinfo('info','Invalid Login')


window = Tk()
window.title('Countries Generation')

frame = Frame(window)

Label1 = Label(window,text = 'Username:')
Label1.pack(padx=15,pady= 5)

entry1 = Entry(window,bd =5)
entry1.pack(padx=15, pady=5)



Label2 = Label(window,text = 'Password: ')
Label2.pack(padx = 15,pady=6)

entry2 = Entry(window, bd=5)
entry2.pack(padx = 15,pady=7)




btn = Button(frame, text = 'Check Login',command = dialog1)


btn.pack(side = RIGHT , padx =5)
frame.pack(padx=100,pady = 19)
window.mainloop()

hope that help you to understand what wrong with the previous code

answered Jan 10, 2017 at 12:26

Midhun Mohan

5825 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Angele Aquilina Over a year ago

I don't use a class because this is for school and we have't done classes yet. Thank you so much I finally understood what I did wrong, you've been great help

Collectives™ on Stack Overflow

Password and Username using Python GUI

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related