Dynamically setting variables in javascript

Question

Trying to dynamically set variables depending how many vimeo iframes are on my page. Im using the Eval method in my code below:

var numberVimeoFrames = jQuery(".vimeo").length;

for(i=1;i<=numberVimeoFrames;i++){
    var refFrame = jQuery('.vimeo:nth-child(' + i + ')');
    eval("player" + i + "= new Vimeo.Player(" + refFrame + ")");
}

My eval line is however generating an error message:

Uncaught SyntaxError: Unexpected identifier

To me it looks like ive concatenated correctly so not sure where ive gone wrong?

refFrame is a jQuery object, not a string, it doesn't make sense to concatenate it. — Barmar
– Barmar, Commented Jan 12, 2017 at 17:26
Any time you think you need dynamic variables, you're probably wrong. You should be using an array or object. When the variables have numeric suffixes like this, it should be an array. — Barmar
– Barmar, Commented Jan 12, 2017 at 17:27
Did you consider var players = jQuery(".vimeo") and then players[i]? — Oriol
– Oriol, Commented Jan 12, 2017 at 17:44

M0nst3R · Accepted Answer · 2017-01-12 17:55:40Z

1

Even though in this case I do not think it is that bad, the general opinion is to not use eval at all. Use arrays instead :

var numberVimeoFrames = jQuery(".vimeo").length;

var players = [];
for(i=1;i<=numberVimeoFrames;i++){
    var refFrame = jQuery('.vimeo:nth-child(' + i + ')');
    players.push(new Vimeo.Player(refFrame));
}

You can now access your players by calling the array (for example players[1] instead of player1 and so on.)

answered Jan 12, 2017 at 17:55

M0nst3R

5,3131 gold badge28 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Dynamically setting variables in javascript

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related