MVC Submit form method not triggering controller

Question

Issue

I have been given a piece of code that was written years ago by someone else and I am trying to get my head around why this piece of code is not working.

I have a Edit.aspx page which inside has a list of hyperlinks and one of these links is a Delete label, but has a RenderPartial in it's place (See Below):

<% Html.RenderPartial("UserDeleteLink", Model); %>

Inside the UserDeleteLink.ascx page it contains the delete button:

<li>
    <% using (Html.BeginForm("Delete", "User", new { id = Model.uID }, FormMethod.Post, new { id = "DeleteForm" }))

    { %> 
        <a class="delete-user-button expired" href="javascript:void(0);"><%: Resources.GeneralDelete %></a>         
 <% } %>
</li>

Now inside the UserController.cs it has a method which deletes the record from the database:

[HttpPost, ActionName("Delete")]
[RequireAdminAttribute]
[Authorize]
public ActionResult DeleteConfirmed(int id)
{
    _userRepository.Delete(id);
    _userRepository.Save();
    return RedirectToAction("Index", "Admin");
}

The problem is that the method is not getting hit, and I can't seem to debug the issue.

Can anyone see the issue?

Is a different action being invoked? What is the request to the server and what is the server's response? — David
– David, Commented Jan 16, 2017 at 15:42
Is the account you are logged in as Authorised? Based off the Authorise tag and AdminAttribute — Bad Dub
– Bad Dub, Commented Jan 16, 2017 at 15:44
What delete button? That's an empty hyperlink, with something very weird in the href. — user1023602
– user1023602, Commented Jan 16, 2017 at 15:44
@buffjape <%: Resources.GeneralDelete %> is "Delete" just in a Resource file. — Ben Clarke
– Ben Clarke, Commented Jan 16, 2017 at 15:45

Matt Spinks · Accepted Answer · 2017-01-16 16:19:02Z

1

There might be 3 things going on here...

Looks like you are not submitting. Try adding a submit button inside your form:
```
<input type='submit' value='Delete' />
```
Check your id param. In your controller, it is an int. But in your form it looks like you are assigning a string. The model binder could be returning an error.
Check your routing config (usually in App_Start). Check to see if it is using the default {controller}/{action}, or if there is some custom routing going on.

And finally, try using F12 debugging tools when submitting the form. Check the network traffic to see exactly what url is being hit, and what parameters are being sent. You can also see some error messages coming back from your POST.

edited Jan 16, 2017 at 16:19

answered Jan 16, 2017 at 15:52

Matt Spinks

6,7404 gold badges32 silver badges57 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Ben Clarke Over a year ago

Just added this and it did not trigger the method.

Matt Spinks Over a year ago

Check your routing configuration. Is the app using the default {controller}/{action} config, or is there some custom routing going on? You also might check the F12 debugging options to see exactly what url is being hit, and if there is any error message (501, 401, etc) coming back.

Irinel Birsan · Accepted Answer · 2017-01-16 15:55:12Z

0

Seems like you don't submit the form.

Try adding onclick="form.submit();" to your link element

<a class="delete-user-button expired" href="javascript:void(0);" onclick="form.submit();"><%: Resources.GeneralDelete %></a>

edited Jan 16, 2017 at 15:55

answered Jan 16, 2017 at 15:47

Irinel Birsan

11 bronze badge

2 Comments

Ben Clarke Over a year ago

Just added this and the method did not trigger.

Irinel Birsan Over a year ago

How is the generated html looking?

CodeReaper · Accepted Answer · 2017-01-16 16:13:34Z

0

Try the below, Remove all attributes from the Action method and simplify the form to the following

//[HttpPost, ActionName("Delete")]
//[RequireAdminAttribute]
//[Authorize]
public ActionResult DeleteConfirmed(int id)
{
    _userRepository.Delete(id);
    _userRepository.Save();
    return RedirectToAction("Index", "Admin");
}

<% using (Html.BeginForm("DeleteConfirmed", "User"))
{ %>
<input name="id" value="1"/>
<input type='submit'/>
<% } %>

or better still, use the HTML form tags to create the form.

Once you get the basic thing working, try one by one to add back the attributes to the ActionMethod and the Form. That should help you pin point why it does not work.

edited Jan 16, 2017 at 16:13

answered Jan 16, 2017 at 16:05

CodeReaper

9252 gold badges8 silver badges23 bronze badges

Collectives™ on Stack Overflow

MVC Submit form method not triggering controller

Issue

3 Answers 3

2 Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

Issue

3 Answers 3

2 Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related