Make array_sum add total in each foreach loop in Laravel PHP.

Question

I have a list of clients who have many appointments in db. I want to iterate through the appointments totalling their duration for each client so I can create an invoice. When I run the below code the first client's appointments duration are added correctly. However my issue is, for the next client it seems to add the first clients duration too. Is array_sum the correct method?? What do i need to use if not?

foreach($clients as $client)
        { 
            $appointments = Client::find($client->id)->appointments()->get();

                foreach($appointments as $appointment)
                {

                    $date1      = $appointment->starts_at; 
                    $date2      = $appointment->ends_at;                        
                    $start      = Carbon::parse($date1);
                    $end        = Carbon::parse($date2);

                    $length     = $start->diffinhours($end);
                    $duration[] = $length;          //is this correct?
                    $total = array_sum($duration);    //is this correct?
                }

            $invoice                    = new Invoice;
            $invoice->total_hours       = $total;   
            dd($invoice);
            $invoice->save();   
        }

after each loop you need to reset the sum. I mean just before the second foreach loop code (after getting $appointments) make you total variable as 0 i.e. $total=0 — BetaDev
– BetaDev, Commented Jan 17, 2017 at 20:53

labue · Accepted Answer · 2017-01-17 20:56:27Z

2

Reset the duration for each client and array_sum after the appointment loop:

foreach ($clients as $client)
{ 
    $appointments = Client::find($client->id)->appointments()->get();

    $duration = array();

    foreach ($appointments as $appointment)
    {
        $date1      = $appointment->starts_at; 
        $date2      = $appointment->ends_at;                        
        $start      = Carbon::parse($date1);
        $end        = Carbon::parse($date2);

        $length     = $start->diffinhours($end);
        $duration[] = $length;
    }

    $total = array_sum($duration);

    $invoice                    = new Invoice;
    $invoice->total_hours       = $total;   
    dd($invoice);
    $invoice->save();   
}

answered Jan 17, 2017 at 20:56

labue

2,6233 gold badges27 silver badges37 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Alexey Mezenin · Accepted Answer · 2017-01-17 21:02:19Z

1

Yes you can use this method, but you need to move it outside the loop and also you should empty $total with each iteration:

....
$duration = [];

foreach ($appointments as $appointment)
{
    $date1      = $appointment->starts_at; 
    $date2      = $appointment->ends_at;                        
    $start      = Carbon::parse($date1);
    $end        = Carbon::parse($date2);

    $length     = $start->diffinhours($end);
    $duration[] = $length;
}

$total = array_sum($duration);
....

Also, you could add start_at and end_at timestamps to the $dates array in a model and use this code instead:

foreach ($appointments as $appointment)
{
    $duration[] = $appointment->starts_at->diffInHours($appointment->ends_at);
}

edited Jan 17, 2017 at 21:02

answered Jan 17, 2017 at 20:56

Alexey Mezenin

164k27 gold badges309 silver badges287 bronze badges

1 Comment

Eden WebStudio Over a year ago

Thanks for this. It works. I have also implemented your suggestion about $dates.

Collectives™ on Stack Overflow

Make array_sum add total in each foreach loop in Laravel PHP.

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related