PHP modulus function Issue

Question

I am trying to create some HTML using php/mysql.

My HTML should be something like below:

<div class="row">
  <div>Content Block</div>
  <div>Content Block</div>  
  <div>Content Block</div>
  <div>Content Block</div>
</div>
<div class="row">
  <div>Content Block</div>
  <div>Content Block</div>  
  <div>Content Block</div>
  <div>Content Block</div>
</div>
..........
<div class="row">
  <div>Content Block</div>
  <div>Content Block</div>  
  <div>Content Block</div>
  <div>Content Block</div>
</div>

There are 4 content divs in each row.

This is how I tried it in my PHP while loop, but its not work for me.

while($stmt->fetch()) {    

  if($i % 4 == 0) {
    $html  = "<div class='row'>\n";
  }

  $html .= "    <div class='checkbox col-sm-3'>\n"; 
  $html .= "       <label>\n"; 
  $html .= "         <input class='custom' name='facility[$fid]' type='checkbox'>\n"; 
  $html .= "         <span class='lbl'> {$fname}</span>\n"; 
  $html .= "       </label>\n";   
  $html .= "    </div>\n";   

  if($i++ % 4 == 4) { 
    $html .= "  </div>\n";
  } 

  $ckbxOurPut[] = $html;
}

Can anybody tell me what it the wrong with this?

Thank you.

what you mean by this if($i++ % 4 == 4) ?. When this satisfy — Azeez Kallayi
– Azeez Kallayi, Commented Jan 19, 2017 at 8:39
what do you mean with "but its not work for me" ? . you have error .. wrong result ? .. no result .. ?. — ScaisEdge
– ScaisEdge, Commented Jan 19, 2017 at 8:39
@scaisEdge. It has a wrong result. It is not printing closing tag for .row div. — user3733831
– user3733831, Commented Jan 19, 2017 at 8:43
its is an array. Because I need to get the output into an array.. — user3733831
– user3733831, Commented Jan 19, 2017 at 8:50

kscherrer · Accepted Answer · 2017-01-19 09:44:04Z

3

if($i++ % 4 == 4) {

$var % 4 can never be 4. What you want is this:

 if($i++ % 4 == 3) {

Edit: also in line 4 you redefine $html, when you should just concatenate (.= operator)

edited Jan 19, 2017 at 9:44

answered Jan 19, 2017 at 8:39

kscherrer

5,7142 gold badges25 silver badges62 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

ᴄʀᴏᴢᴇᴛ Over a year ago

@user3733831 yet, this answer is correct, i just tested it and it works fine.

Niklesh Raut Over a year ago

@C̲̅R̲̅O̲̅Z̲̅E̲̅T̲̅ this was definitely an issue, but may be $ckbxOurPut[] = $html; is another problem

ᴄʀᴏᴢᴇᴛ · Accepted Answer · 2017-01-19 09:08:05Z

1

First, you have to change if($i++ % 4 == 4) to if($i++ % 4 == 3)

Also, on line 4 of your code, you use $html = "<div class='row'>\n"; instead of $html .= "<div class='row'>\n";.

answered Jan 19, 2017 at 9:08

ᴄʀᴏᴢᴇᴛ

3,01029 silver badges44 bronze badges

Comments

Niklesh Raut · Accepted Answer · 2017-01-19 09:06:53Z

1

Make this changes 1. Modulus changes 2. Push html in array after outer div close.

 if($i++ % 4 == 3) { 
   $html .= "  </div>\n";
   $ckbxOurPut[] = $html;
 }

answered Jan 19, 2017 at 9:06

Niklesh Raut

34.9k17 gold badges82 silver badges112 bronze badges

Comments

zakrzu · Accepted Answer · 2017-01-19 08:52:37Z

0

<?php
$a = [
    1,2,3,4,5,6,7,8,9,0,11,12,13
];

$i = 0;
$html = "";
foreach($a as $val)
{



   if($i % 4 == 0) {
     $html  .= "<div class='row'>\n";
   }

  $html .= $val."\n";          

   if($i++ % 4 == 3) { 
     $html .= "  </div>\n";
   } 

} 

 if($i % 4 != 3) { 
     $html .= "  </div>\n";
 } 


echo $html;

edited Jan 19, 2017 at 8:52

answered Jan 19, 2017 at 8:47

zakrzu

5954 silver badges9 bronze badges

2 Comments

ᴄʀᴏᴢᴇᴛ Over a year ago

anything modulus 4 will never give 4 so the div will never be closed

zakrzu Over a year ago

of course, I forgot change condition to: if($i % 4 == 3)

mith · Accepted Answer · 2017-01-19 09:07:44Z

0

Try this:

$i = 0;
$html  = "<div class='row'>";

while($stmt->fetch()) {

    $i++;
    if($i == 5) {
         $html  .= "</div><div class='row'>";
         $i = 1;
     }

     $html .= "    <div class='checkbox col-sm-3'>\n";
     $html .= "       <label>\n";
     $html .= "         <input class='custom' name='facility[$fid]' type='checkbox'>\n";
     $html .= "         <span class='lbl'> {$fname}</span>\n";
     $html .= "       </label>\n";
     $html .= "    </div>\n";


}

$html  .= "</div>";
echo $html;

answered Jan 19, 2017 at 9:07

mith

1,7001 gold badge10 silver badges13 bronze badges

Collectives™ on Stack Overflow

PHP modulus function Issue

5 Answers 5

2 Comments

Comments

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

Comments

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related