Array of hashes is overriding data directly to array

Question

I want to make an array of hashes. But the problem is after first iteration when code goes to next line then it directly replaces the content of array.

@item_name =[]
item = {}
@invoiceinfo.each do |invoice|
  item[:name] =  Invoiceinfo.find(@invoiceinfo.id).item.name
  item[:desc] =  Invoiceinfo.find(@invoiceinfo.id).desc
  item[:unit_price] =  Invoiceinfo.find(@invoiceinfo.id).unit_price
  byebug
  @item_name.push (item)
end

This is what i am getting after first iteration suppose i have this data

@item_name = [{:name=>"usman", :desc=>"sample ", :unit_price=>100}]

As soon as next line is executed it directly changes @item_name(name variable) After executing item[:name] = Invoiceinfo.find(@invoiceinfo.id).item.name the content of the @item_name is changed

@item_name = [{:name=>"next_name", :desc=>"sample ", :unit_price=>100}]

Any help would be appreciated. Thannks

There's a good answer, but to clarify what you're doing wrong you're just reassigning the value to the same keys over and over. — OneNeptune
– OneNeptune, Commented Jan 22, 2017 at 13:59

Ursus · Accepted Answer · 2017-01-22 13:58:00Z

4

Try something like this

@item_name = []
@invoiceinfo.each do |invoice|
  invoice_info = Invoiceinfo.find(@invoiceinfo.id)

  item = {}
  item[:name] =  invoice_info.item.name
  item[:desc] =  invoice_info.desc
  item[:unit_price] = invoice_info.unit_price

  @item_name.push(item)
end

answered Jan 22, 2017 at 13:58

Ursus

30.1k3 gold badges36 silver badges52 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Zia Qamar Over a year ago

Thanks, i was not re-initializing the hash.

Ursus Over a year ago

Exactly. And I made one SQL query for iteration, not three :) You're welcome

Cary Swoveland Over a year ago

Good to see you provided the third line of code as a bonus.

Aleksei Matiushkin · Accepted Answer · 2017-01-22 14:20:38Z

4

If you consider using ruby paradigms and best practices in ruby code, this mistake won’t happen in the future.

@item_name = @invoiceinfo.each_with_object([]) do |invoice, acc|
  invoice_info = Invoiceinfo.find(@invoiceinfo.id)

  acc.push(
    name: invoice_info.item.name,
    desc: invoice_info.desc
    unit_price: invoice_info.unit_price
  )
end

answered Jan 22, 2017 at 14:20

Aleksei Matiushkin

121k12 gold badges109 silver badges174 bronze badges

Collectives™ on Stack Overflow

Array of hashes is overriding data directly to array

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related