Problem with memory manament in Objective-C

Question

I have a method:

-(NSArray   *)doSomething{

    NSArray *array = [[NSArray alloc] initWithObjects:@"Huy 1",@"Huy 2",@"Huy 3",nil];

    [array  release];

    return  array;

}

and

- (void)viewDidLoad {

    [super viewDidLoad];

    NSArray *array  =   [self   doSomething];

    if(array&&array.count>0){

        NSLog([NSString stringWithFormat:@"%@\n",[array objectAtIndex:1]]);

    }
    else{

        NSLog(@"Null");

    }

}

I thinks i released array on doSomething() so it won't return NSArray which i created on doSomething(). I don't know it still print "Huy 2"? Anybody can tell me why?

Benedict Cohen · Accepted Answer · 2010-11-17 09:11:44Z

2

-(NSArray *)doSomething
{
    NSArray *array = [[NSArray alloc] initWithObjects:@"Huy 1",@"Huy 2",@"Huy 3",nil];

    return  [array autorelease];
}

Memory Management Programming Guide

- (void)viewDidLoad 
{
    [super viewDidLoad];
    NSArray *array  =   [self doSomething];

    if([array count]) //if array is nil this will evaluate to false. If count is 0 this will evaluate to false too.
    {
        NSLog(@"%@\n", [array objectAtIndex:1]); //NSLog insert values for you
    }
    else
    {
        NSLog(@"Null");
    }
}

If this works with release instead of autorelease it's probably because the memory that the array was using has yet to be used by anything else. This is just chance. I suspect that if you allocate an object after NSArray *array = [self doSomething]; you will get unexpected results.

edited Nov 17, 2010 at 9:11

answered Nov 15, 2010 at 11:01

Benedict Cohen

11.9k7 gold badges57 silver badges69 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Sagar · Accepted Answer · 2010-11-15 10:59:52Z

1

Use the method in following way:

-(NSArray   *)doSomething{

    NSArray *array = [[NSArray alloc] initWithObjects:@"Huy 1",@"Huy 2",@"Huy 3",nil];

    return  [array autorelease];

}

answered Nov 15, 2010 at 10:59

Sagar

3,1493 gold badges31 silver badges28 bronze badges

Collectives™ on Stack Overflow

Problem with memory manament in Objective-C

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related