`global` name not defined error when using class variables

Question

For some reason I'm getting a global name is not defined error here. The issue lies in the addClient method where I am incrementing my global variable joinID. It throws me an error NameError: global name 'joinID' is not defined. What am I doing wrong?

class Chatroom:
    clients = []
    joinID = 0

    def __init__(self,name,refNum):
        self.refNum = refNum
        self.name = name

    def addClient(self,clientName):
        global clients
        global joinID
        joinID = joinID+1
        clients.append(clientName, joinID)

    def removeClient(self, clientName, joinID):
        global clients
        clients.remove(clientName, joinID)

Your indentation looks broken. Also, are you aware of the difference between "x" and "self.x"? — Bryan Oakley
– Bryan Oakley, Commented Jan 26, 2017 at 19:13
Quite simply, joinID is not defined. Nowhere is there a joinID variable declared. — Octo
– Octo, Commented Jan 26, 2017 at 19:13

Shoo Limberger · Accepted Answer · 2017-01-26 19:26:45Z

In a method from a class is bether to use a instance attribute or a class atribute. In this case you are using a class atribute.

class Chatroom:
    clients=[]
    joinID=0

    def __init__(self,name,refNum):
        self.refNum=refNum
        self.name=name

    def addClient(self,clientName):
        self.joinID=self.joinID+1
        self.clients.append((clientName,self.joinID))

    def removeClient(self,clientName,joinID):
        self.clients.remove((clientName,joinID))

If you wan´t to use global, you must declare the variable in the global scope:

joinId=0
clients=[]
class Chatroom:

    def __init__(self,name,refNum):
        self.refNum=refNum
        self.name=name

    def addClient(self,clientName):
        global joinID
        global clients
        joinID=joinID+1
        clients.append((clientName,joinID))

    def removeClient(self,clientName,joinID):
        global clients
        clients.remove((clientName,joinID))

Shijo · Accepted Answer · 2017-01-26 19:14:52Z

1

Take the variables outside the class

joinID=0
clients=[]
class Chatroom:
    def __init__(self,name,refNum):

answered Jan 26, 2017 at 19:14

Shijo

9,7813 gold badges23 silver badges31 bronze badges

1 Comment

Martijn Pieters Over a year ago

or use the self. prefix to look up the variables via the instance, or Chatroom. prefix to access them via the class.

Collectives™ on Stack Overflow

`global` name not defined error when using class variables

2 Answers 2

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related