filter array method javascript

Question

could you please tell me why my script is broken? It is an exercise in a Udemy lesson. You need only returning users who have admin level access

var users = [
 { id: 1, admin: true },  
 { id: 2, admin: false },
 { id: 3, admin: false },
 { id: 4, admin: false },
 { id: 5, admin: true },
];

var filteredUsers;

function isAdmin(array, property){
     return array.filter(function(key){
        return key[property] === 'true';
})
}

filteredUsers = isAdmin(users, 'admin');

Thank you

I think isAdmin is a "predicate," and should be used as the function inside .filter(). Also, calling it "isAdmin" and giving it the property name is redundant. Shouldn't isAdmin always know it should check the admin property? — Harry Pehkonen
– Harry Pehkonen, Commented Feb 2, 2017 at 16:21

Nina Scholz · Accepted Answer · 2017-02-02 15:26:05Z

2

You need to test against a boolean value, because your data has true or false values.

return key[property] === true;
//                       ^^^^

function isAdmin(array, property) {
    return array.filter(function (key) {
        return key[property] === true;
        //                       ^^^^
    });
}

var users = [{ id: 1, admin: true }, { id: 2, admin: false }, { id: 3, admin: false }, { id: 4, admin: false }, { id: 5, admin: true }],
    filteredUsers = isAdmin(users, 'admin');

console.log(filteredUsers);

edited Feb 2, 2017 at 15:26

answered Feb 2, 2017 at 15:19

Nina Scholz

388k26 gold badges367 silver badges417 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

László Péter Varga Over a year ago

Thank you As you have pointed to the boolen value it made me understand it. I just did not realized it.

Community · Accepted Answer · 2017-05-23 10:29:27Z

0

)Your problem is that your are using the 3 equal sing ("===") to test the proprety. Here's a link with more details that explains the difference between :

https://stackoverflow.com/a/523650/5235299

edited May 23, 2017 at 10:29

CommunityBot

11 silver badge

answered Feb 2, 2017 at 15:33

slou

441 silver badge6 bronze badges

2 Comments

Harry Pehkonen Over a year ago

Depends on your perspective. The way I see it, using the three equal signs is the correct thing to do, but you need to compare to true, not to "true". But this may be a religious issue to some people (like myself ;D).

László Péter Varga Over a year ago

The problem was that I didn't realise the boolean values as property but strings. As Nina pointed it out I understood straight and realised my mistake.

Collectives™ on Stack Overflow

filter array method javascript

2 Answers 2

1 Comment

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related