Segmentation Fault when accessing global integer array

Question

I am writing C code to take user parameters and build an integer array from them. I ask the user to provide the array length and each element's value.

Running the following code causes an error at the printArray() function call. Following the debugger into printArray(), the Segmentation Fault itself occurs at printf("%d", intArray[i])

NOTE: The array is correctly printed when I copy the printArray() code into main() instead of making a function call. This makes me think that I have an issue with global variables and/or pointers. I am still learning C, so your guidance is appreciated.

How can I fix this? See debugger output at the bottom for more info.

void printArray();

int arraySize;
int* intArray;

int main() {

    printf("Enter array length:\n");

    scanf("%d", &arraySize);
    int* intArray = (int*) malloc(sizeof(int)*arraySize);

    printf("Enter an integer value for each array element:\n");
    for (int i = 0; i < arraySize; i++) {
        printf("Enter element %d:\n", i);
        scanf("%d", &intArray[i]);
    }

    printArray();
    return 0;
}

void printArray() {
    printf("[");

    for (int i = 0; i < arraySize; i++) {
      printf("%d", intArray[i]);
    }
    printf("]\n");
}

No, at least not intentionally. Although Rajesh posted the solution below, I wonder about that Thread 2 part. Perhaps main() gets its own thread? — nxheller
– nxheller, Commented Feb 5, 2017 at 8:12

333 · Accepted Answer · 2017-02-05 07:45:29Z

2

I think you have redeclared intArray variable in main()

int* intArray = (int*) malloc(sizeof(int)*arraySize);

by doing this, the scope of this variable is only in the main function and printArray() does not know about this definition. So printArray() tries to access intArray variable which you have declared globally(which does not have definition) and thus leading to segmentation fault.

So just give intArray = (int*) malloc(sizeof(int)*arraySize);

edited Feb 5, 2017 at 7:45

answered Feb 5, 2017 at 7:38

333

1581 silver badge10 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

nxheller Over a year ago

thank you. I had moved the intArray declaration into global space for the express purpose of using printArray() and forgot to remove the declaration portion inside main()

Collectives™ on Stack Overflow

Segmentation Fault when accessing global integer array

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related