Boolean class missing a return statement java

Question

I want to check if the two arrays have the same elements, but it says missing return statement although I have returned as below. What's the problem? My method can get correct value if I write in a void function.

public static boolean get(int[] One, int[] Two, int target) {
    int [] temp = new int[One.length];
    for (int i = 0 ; i < One.length; i ++){
        temp[i] = target - One[i];
    }

    for (int m = 0; m < temp.length; m++){
        for (int n = 0; n < Two.length; n ++){
            if (temp[m]==Two[n]){
                return true;
            }  
           else return false;
        }

    }

}

your code is not true at all , i've answered it how to remove this bug , but i think your code is not true ... — Mohsen_Fatemi
– Mohsen_Fatemi, Commented Feb 9, 2017 at 22:45

jarthur · Accepted Answer · 2017-02-09 22:40:37Z

1

The compiler won't accept it because it is possible to reach the end without ever returning anything. You can structure it like this so that no matter what the input is, it will always return true or false.

public static boolean get(int[] One, int[] Two, int target) {
    int [] temp = new int[One.length];

    for (int i = 0 ; i < One.length; i ++){
        temp[i] = target - One[i];
    }

    for (int m = 0; m < temp.length; m++){
        for (int n = 0; n < Two.length; n ++){
            if (temp[m]==Two[n]){
                return true;
            } 
            else {
                return false;
            } 
        }
    }

    return false;
}

edited Feb 9, 2017 at 22:40

answered Feb 9, 2017 at 22:32

jarthur

4221 gold badge3 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Mohsen_Fatemi Over a year ago

it is not efficient , try to return true in for loop

Mohsen_Fatemi Over a year ago

you are new to stackoverflow , look at the op , it returns false in the else add it to , i'm not gonna downvote your solution , correct it , i'll upvote it :)

Mohsen_Fatemi Over a year ago

be aware of these little things , in stackoverflow people gonna downvote such answers , so you can't get promotion in it , good luck ;)

Mohsen_Fatemi Over a year ago

where are you from ?

Matt Wisniewski · Accepted Answer · 2017-02-09 22:33:03Z

0

It's possible for the function to finish without returning if either temp.length or Two.length are 0.

answered Feb 9, 2017 at 22:33

Matt Wisniewski

918 bronze badges

Comments

Mohsen_Fatemi · Accepted Answer · 2017-02-09 22:33:36Z

0

i have no idea what you gonna do , but if you add a return false; into the last line of your method , it would work

public static boolean get(int[] One, int[] Two, int target) {
    int [] temp = new int[One.length];
    for (int i = 0 ; i < One.length; i ++)
        temp[i] = target - One[i];

    for (int m = 0; m < temp.length; m++){
        for (int n = 0; n < Two.length; n ++){
            if (temp[m]==Two[n]) return true;
            else return false;
        }
    }
    return false;
}

answered Feb 9, 2017 at 22:33

Mohsen_Fatemi

3,4212 gold badges21 silver badges32 bronze badges

Comments

Pali · Accepted Answer · 2017-02-09 22:59:27Z

0

Think about what will happen if temp.length is 0 ...

answered Feb 9, 2017 at 22:59

Pali

1,3671 gold badge15 silver badges43 bronze badges

Collectives™ on Stack Overflow

Boolean class missing a return statement java

4 Answers 4

4 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

4 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related