Assign Session value using properties in mvc

Question

So, here is the idea.I have a SessionCache class which is to get and set session variables which is simple user info.So I want to set values to session once user is successfully logged in and use this class to get session values throughout the application.But somehow I am not able to set the values to session variable in the SessionCache class.

public class SessionCache
{
    public static string SessionID
    {
        get
        {
            return HttpContext.Current.Session.SessionID;
        }
    }
    public static CurrentUserVM CurrentUser
    {
        get
        {
            return (CurrentUserVM)HttpContext.Current.Session["CurrentUser"];
        }
        set
        {
            HttpContext.Current.Session["CurrentUser"] = CurrentUser;
        }
    }
}

So, Im trying to set values using the above class in login action as below:

CurrentUserVM currentUser = new CurrentUserVM();
currentUser.User = db.userClass.FirstOrDefault(m => m.EmailID.Equals(objLogin.EmailID));
currentUser.isAuthenticated = true;
SessionCache.CurrentUser = currentUser;
SessionCache.CurrentUser.isAuthenticated = currentUser.isAuthenticated;

but still the SessionCache.CurrentUser remains null.Is there something wrong with my code?

This is a very bad idea, though, at least for the data you're storing. Things like whether or not the user is authenticated shouldn't be stored in the session. That can be retrieved at any time via User.Identity.IsAuthenticated, anyways, so there's really no reason to. Like info like the user's email address should come from the database always. There's very little cost in retrieving the user record, especially since Entity Framework employs its own query cache, and then you're not responsible for remember to always update stuff in the session. — Chris Pratt
– Chris Pratt, Commented Feb 10, 2017 at 18:07
I totally agree to whatever you said there.But this doesnt deal with a lot of data and is merely redirecting users to different parts of the website once logged in.I am not using the user data that much here.This app is too simple to use Identity.but thanks anyways.@ChrisPratt — Mash
– Mash, Commented Feb 11, 2017 at 8:00

jtabuloc · Accepted Answer · 2017-02-10 17:44:32Z

1

I think the problem is obvious. Just simple change this

HttpContext.Current.Session["CurrentUser"] = CurrentUser;

into this

HttpContext.Current.Session["CurrentUser"] = value;

answered Feb 10, 2017 at 17:44

jtabuloc

2,5352 gold badges20 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Mash Over a year ago

what was I even thinking..sheesh.Thank you

jtabuloc Over a year ago

@Mash, You're welcome, don't forget to mark this as answer if does solve you problem. Thanks :)

Collectives™ on Stack Overflow

Assign Session value using properties in mvc

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related