Javascript Filter Refactor

Question

I am filtering an array of objects using a function that looks like this

 var val = 'some text value'  

 this.someList = this.someList.filter(containsQuery);

        function containsQuery(listItem) {

        return   listItem.Key_One.toLowerCase().indexOf(val) > -1 ||
                 listItem.Key_Two.toLowerCase().indexOf(val) > -1 ||
                 listItem.Key_Three.toLowerCase().indexOf(val) > -1
        }

My question is what is a better way of filtering on each of the list item key values without having to write a new line for each one? i.e so I can avoid going

listItem.Key_Four.toLowerCase().indexOf(val) > -1
listItem.Key_Five.toLowerCase().indexOf(val) > -1

etc..

Any advice would be great.

Thanks!

Nina Scholz · Accepted Answer · 2017-02-13 11:27:00Z

3

You could use get keys of the object with Object.keys and iterate with Array#some.

function containsQuery(listItem) {
    return Object.keys(listItem).some(function (k) {
        return listItem[k].toLowerCase().indexOf(val) > -1;
    });
}

answered Feb 13, 2017 at 11:27

Nina Scholz

388k26 gold badges367 silver badges417 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Vic · Accepted Answer · 2017-02-13 11:28:22Z

2

Just a suggestion, array containing all the keys and loop them?

Like

var keys = ['key_one', 'key_two', 'key_three', 'key_four'];
for (i=0; i<keys.length; i++){
if (listItem[keys[i]].toLowerCase().indexOf(val) > -1) return true;
}
return false;

Ah damn, same idea as above, just took too long writing :D

answered Feb 13, 2017 at 11:28

Vic

438 bronze badges

Collectives™ on Stack Overflow

Javascript Filter Refactor

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related