String matching within nested for loop

Question

Lets say i have two different Strings of given pojo type.

 List 1 = "one", "two", "three", "four", "five".
 List 2 = "one", "two", "four", "five".

I wants to retrieve a string that doesn't found in another list and add it into another list(say List 3). how can i do this?

i'm trying this:-

 for ( SettlementReportNB showSellementReport : settlementReportList )
        {
            String merchantreferencenumber = showSellementReport.getMerchantreferencenumber();
            for ( AllTransactions showAllTransaction : allTransactionsList )
            {
                String merchantTxnId = showAllTransaction.getMerchantTxnId();
                if ( !merchantreferencenumber.equals( merchantTxnId ) )
                {
                    idNotFound.add( merchantTxnId );
                }
            }
        }

but it is not giving me an expected answer.

Answer should be "three" because it is not present in another list.

what is your expected result and what are you getting right now — RamPrakash
– RamPrakash, Commented Feb 16, 2017 at 12:37
The answer here exposes a simple way of doing set operations on lists stackoverflow.com/questions/3590677/… — RubioRic
– RubioRic, Commented Feb 16, 2017 at 12:41

Sergey Kalinichenko · Accepted Answer · 2017-02-16 12:42:25Z

2

You are adding the string to result too soon. Your code has to wait for the loop to finish before calling idNotFound.add();

Define a boolean variable notFound, and set it to true before the loop. If you find a match in the loop, set the variable to false, and break out of the loop.

If the variable remains true after the loop is over, call idNotFound.add();

answered Feb 16, 2017 at 12:42

Sergey Kalinichenko

729k85 gold badges1.2k silver badges1.6k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mouad EL Fakir · Accepted Answer · 2017-02-16 13:06:40Z

1

Or you could something like this:

List list1 = Arrays.asList("one", "two", "three", "four", "five");
List list2 = Arrays.asList("one", "two", "four", "five");

//create a clone of list1
List list3 = new ArrayList<>(list1);

//remove all elements of list2 from list1
list3.removeAll(list2);

//output : [three]
System.out.print(list3);

You will end up wit list3 that has only [three]

Or try something like this to keep your existing code :

for ( SettlementReportNB showSellementReport : settlementReportList ) {

    String allTransactionsList = showSellementReport.getMerchantreferencenumber();

    if ( isNotContain(allTransactionsList, allTransactionsList))
    {
        idNotFound.add( merchantTxnId );
    }

}

private boolean isNotContain(List allTransactionsList, String merchantreferencenumber) {

    for ( AllTransactions showAllTransaction : allTransactionsList )
    {
        String merchantTxnId = showAllTransaction.getMerchantTxnId();
        if ( merchantreferencenumber.equals( merchantTxnId ) )
        {
            return false;
        }
    }

    return true;
}

edited Feb 16, 2017 at 13:06

answered Feb 16, 2017 at 12:42

Mouad EL Fakir

3,8092 gold badges27 silver badges40 bronze badges

2 Comments

RamPrakash Over a year ago

what if user wants the original list1 contents?

Mouad EL Fakir Over a year ago

easy check the post again (create a new copy of list1)

Guilherme Bernert · Accepted Answer · 2017-02-16 13:16:49Z

1

If you need to verify all the elements that are not present in the second list only, just create a Set and use the !contains from the first list, if you need to verify both lists then add the second for from the example below:

Set<String> list3 = new HashSet<String>();
for (String text : list1) {
  if (!list2.contains(text)) list3.add(text);
}
for (String text : list2) {
  if (!list1.contains(text)) list3.add(text);
}

answered Feb 16, 2017 at 13:16

Guilherme Bernert

112 bronze badges

Comments

Murat Karagöz · Accepted Answer · 2017-02-16 12:44:48Z

Your second for loop does not check every element. It checks only if one element does not match the compared String. You have to iterate over the whole list before you are sure it's not already present e.g.

for (SettlementReportNB showSellementReport: settlementReportList) {

    boolean notPresent = false;
    String merchantTxnId = null;
    String merchantreferencenumber = showSellementReport.getMerchantreferencenumber();
    for (AllTransactions showAllTransaction: allTransactionsList) {
        merchantTxnId = showAllTransaction.getMerchantTxnId();
        if (merchantreferencenumber.equals(merchantTxnId)) {
            notPresent = false;
            break; // get out of loop because it already exists
        } else {
            notPresent = true;
        }
    }
    if (notPresent) idNotFound.add(merchantTxnId);
}

Or you could use any of the other answers with List.util functions

Boris Zhguchev · Accepted Answer · 2017-02-16 12:49:05Z

0

May be this case

        List<String> a1 = new ArrayList<>(Arrays.asList( "one", "two", "three", "four", "five"));
        List<String> a2 = new ArrayList<>(Arrays.asList( "one", "two", "four", "five"));

        Set<String> s1 = new HashSet<>(a1);
        Set<String> s2 = new HashSet<>(a2);

        s2.removeAll(s1);

        List<String> a3 = new ArrayList<>(s2);

        List<String> result =  new ArrayList<>(Arrays.asList( "six"));
        result.addAll(a3);

answered Feb 16, 2017 at 12:49

Boris Zhguchev

3144 silver badges13 bronze badges

Comments

Binyamin Regev · Accepted Answer · 2017-02-16 13:05:02Z

0

If you are using Java 8 then use Lambdas - it will be much faster and will save you a loop.

answered Feb 16, 2017 at 13:05

Binyamin Regev

1,0825 gold badges23 silver badges35 bronze badges

Comments

depperm · Accepted Answer · 2017-02-16 14:33:35Z

0

List a = new ArrayList(asList("one", "two", "three", "four", "five"));
List b = new ArrayList(asList("one", "two", "four", "five"));
List c = new ArrayList();
c.addAll(a);
c.addAll(b);
c.removeIf(o -> a.contains(o) && b.contains(o));

edited Feb 16, 2017 at 14:33

depperm

10.8k4 gold badges46 silver badges68 bronze badges

answered Feb 16, 2017 at 13:30

poyger

6662 gold badges9 silver badges17 bronze badges

Collectives™ on Stack Overflow

String matching within nested for loop

7 Answers 7

Comments

2 Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

7 Answers 7

Comments

2 Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related