Loop in Angular

Question

I need help with my loop. I try to get data from Google Finance API. Google doesn't provide multi-tiker API so 1 request per 1 ticker. For 1 ticker, it's work well, but I need more than one. I try to do it in a loop but I get

undefined[object Object][object Object]

  .controller('currency', function ($scope, $http){
  var tickers =["EURUSD","AUDUSD]; 
    for (i = 0; i < 2; i++) {
   $http.get('https://www.google.com/finance/info?q=CURRENCY%3a'+tickers[i]).then(function successCallback(response) {
              $scope.currencydata = $scope.currencydata + JSON.parse(response.data.substr(3));


        })}
    })

I think there is a missing closing quotation mark in var tickers =["EURUSD","AUDUSD"]; — Ernis
– Ernis, Commented Feb 17, 2017 at 6:51

Vladimir Zdenek · Accepted Answer · 2017-02-17 06:49:15Z

1

The JSON.parse method outputs an object. You cannot do a plus operation on two objects.

Change the following:

$scope.currencydata = $scope.currencydata + JSON.parse(response.data.substr(3));

To this:

$scope.currencydata.push(JSON.parse(response.data.substr(3)));

Make sure to initialize the $scope.currencydata variable before the loop.

$scope.currencydata = [];

Otherwise the .push method will not be available.

answered Feb 17, 2017 at 6:49

Vladimir Zdenek

2,2901 gold badge20 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

vijay · Accepted Answer · 2017-02-17 06:53:36Z

0

Use $q.all in angular

Do some thing like

var functionsToFire = []
["EURUSD","AUDUSD].forEach(function(currncy){
   var hello = create http request function
   functionsToFire.push(hello)
})

$q.all(functionsToFire).then(function (result) {
 console.log(result)
});

AND ULTIMATELY IT SHOULD LOOK LIKE THIS

$q.all([request1function, request2function, request3function, request4function]).then(function(result){
    for (var i = 0; i < result.length; i++){
        theResults.push(result[i]);
    }
});

edited Feb 17, 2017 at 6:53

answered Feb 17, 2017 at 6:48

vijay

11.2k12 gold badges67 silver badges83 bronze badges

Comments

hurricane · Accepted Answer · 2017-02-17 06:59:08Z

0

You forgot ". Try this:

 .controller('currency', function ($scope, $http){
      var tickers =["EURUSD","AUDUSD"]; 
        for (i = 0; i < 2; i++) {
       $http.get('https://www.google.com/finance/info?q=CURRENCY%3a'+tickers[i]).then(function successCallback(response) {
                  $scope.currencydata = $scope.currencydata + JSON.parse(response.data.substr(3));


            })}
        })

answered Feb 17, 2017 at 6:59

hurricane

6,7342 gold badges38 silver badges45 bronze badges

1 Comment

user2104618 Over a year ago

yea loss " when copy. Thx

Collectives™ on Stack Overflow

Loop in Angular

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related