How to upload file in Drupal 7 with forms?

Question

I have troubles with Drupal 7 and file uploading.

My code that doesn't work:

function test_form($form, &$form_state){

$form['#attributes'] = array('enctype' => "multipart/form-data");
$form['podcast'] = array(
    '#title' => 'Audio file',
    '#type' => 'file',
);
$form['submit'] = array(
    '#type' => 'submit',
    '#value' => t('Save'),
);
return $form;

}

function test_form_submit($form, &$form_state){

$vals = $form_state['values'];
$filepath = 'public://test/';
//$filepath = 'temporary://test/';
$filename = 'rcc_date.mp3';

file_prepare_directory($filepath, FILE_CREATE_DIRECTORY);
$file = file_save_upload('podcast', array('file_validate_extensions' => array()), $filepath.$filename);
//got FALSE here. Why?
die(print_r($file===FALSE).'-');

}

So path created but file doesn't uploads and file_save_upload returns FALSE. Also I tried array() and true as $validators with no effect.

Any help greatly appreciated. Thanks.

The filename is completely unnecessary in this code. Leave it out completely. Don't set the $filename variable, and don't append it to $filepath. — Magmatic
– Magmatic, Commented Dec 3, 2015 at 17:54
To use an empty array of file validators, like array('file_validate_extensions' => array()), is unsafe and shouldn't be used. Use NULL instead, to take the default, or make a real list yourself. See the note in api.drupal.org/api/drupal/includes!file.inc/function/… — Magmatic
– Magmatic, Commented Dec 3, 2015 at 17:59

lifecoder · Accepted Answer · 2010-11-20 15:58:39Z

4

Doh. $destination shouldn't contain filename, just path.

answered Nov 20, 2010 at 15:58

lifecoder

1,4341 gold badge15 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Magmatic Over a year ago

For those of you wondering where $destination is, it's the third argument to file_save_upload. That line should look like this: $file = file_save_upload('podcast', array('file_validate_extensions' => array()), $filepath); Or preferably, like this: $file = file_save_upload('podcast', null, $filepath); This is a lot more secure. It doesn't allow PHP files, for example, to be uploaded, which would be a huge security risk. See api.drupal.org/api/drupal/includes!file.inc/function/…

Collectives™ on Stack Overflow

How to upload file in Drupal 7 with forms?

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related