Error inserting data into SQL

Question

I have a C# Winform app witch uses the following SQL insert code but for some reason i get an error, the statement is:

 private void button1_Click(object sender, EventArgs e)
        {
            if (desemp.Text != "" && valu.Text != "" && fs.Text != "" && sel.Text != "" && desc.Text != "" && ench.Text != "" && comp.Text != "")
            {
                cmd = new SqlCommand("insert into dbo.vidros(desempenho,valu,fs,sel,desc,enchimento,compo) values (@desemp,@valu,@fs,@sel,@desc,@ench,@comp)", con);
                con.Open();
                cmd.Parameters.AddWithValue("@desemp", desemp.Text);
                cmd.Parameters.AddWithValue("@valu", valu.Text);
                cmd.Parameters.AddWithValue("@fs", fs.Text);
                cmd.Parameters.AddWithValue("@sel", sel.Text);
                cmd.Parameters.AddWithValue("@desc", desc.Text);
                cmd.Parameters.AddWithValue("@ench", ench.Text);
                cmd.Parameters.AddWithValue("@comp", comp.Text);
                cmd.ExecuteNonQuery();
                con.Close();
                MessageBox.Show("sucess!");
            }
            else
            {
                MessageBox.Show("Error!");
            }
        }

The error i get is: Incorrect Syntax near the word 'desc'. I lost hours trying to figure this one out and cant find the fault.

Can anyone help?

Thanks in advance

desc is indeed a keyword. Use [desc] (with square brackets) if you really want to stick to it, although, I would not recommend it. — Jens
– Jens, Commented Feb 20, 2017 at 15:59
@JonSkeet yup that got rid of the error but for some reason the insert does not work, i get a sucess message but no data got into the DB — septaug
– septaug, Commented Feb 20, 2017 at 16:02
you may also need to add cmd.CommandType before cmd.ExecuteNonQuery(); — Rahul Hendawe
– Rahul Hendawe, Commented Feb 20, 2017 at 16:07

Emre BOSTAN · Accepted Answer · 2017-02-20 16:03:50Z

2

 SqlParameter[] Prms = new SqlParameter[] {
            new SqlParameter("desemp", desemp.Text),
            new SqlParameter("valu", valu.Text),
            new SqlParameter("fs", fs.Text),
            new SqlParameter("sel", sel.Text),
            new SqlParameter("desc", desc.Text),
            new SqlParameter("ench", ench.Text),
            new SqlParameter("comp", comp.Text),
        };


cmd.Parameters.AddRange(Prms);

Check the cell names and use them like this.

answered Feb 20, 2017 at 16:03

Emre BOSTAN

431 silver badge7 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

LarsTech Over a year ago

This is just a different way to add parameters. This answer doesn't address the error.

SashaStojanovic · Accepted Answer · 2017-02-20 17:14:12Z

0

If you copy and paste that SQL code into your management studio, you will see that "desc" is highlighted meaning that it is a reserved keyword, used for ordering queries.

Just change desc to [desc] and it should work.

answered Feb 20, 2017 at 17:14

SashaStojanovic

3413 silver badges16 bronze badges

Comments

ASH · Accepted Answer · 2017-02-23 18:21:19Z

0

A Button Click Event, using textBoxes, may look like this:

using System.Data.SqlClient;

protected void Button1_Click(object sender, EventArgs e)
{
SqlConnection con = new SqlConnection(System.Configuration.
ConfigurationManager.ConnectionStrings["con"].ToString());
    try
    {
        string query = "insert into UserDetail(Name,Address) 
        values('" + txtName.Text + "','" + txtAddress.Text + "');";
        SqlDataAdapter da = new SqlDataAdapter(query, con);
        con.Open();
        da.SelectCommand.ExecuteNonQuery();
        con.Close();
        lblmessage.Text = "Data saved successfully.";
    }
    catch
    {
        con.Close();
        lblmessage.Text = "Error while saving data.";
    }

answered Feb 23, 2017 at 18:21

ASH

20.5k28 gold badges115 silver badges247 bronze badges

Collectives™ on Stack Overflow

Error inserting data into SQL

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related