PHP File Upload upload the file even if statement is not correct

Question

HTML:

<form action="" method="post" enctype="multipart/form-data">
    Select file to upload:
    <input type="file" name="fileToUpload" id="fileToUpload">
    <input type="password" name="filepassword" id="filepassword">
    <input type="submit" value="Upload File" name="submit">
</form>

PHP:

<?php 
if(isset($_POST["submit"])) {
    $target_dir = "uploads/";
    $target_file = $target_dir . basename($_FILES["fileToUpload"]["name"]);
    $valueOne =trim($_POST["filepassword"]);
    if($valueOne != "1212"){
        move_uploaded_file($_FILES["fileToUpload"]["tmp_name"], $target_file);
        echo "file uploaded successfully !";
    }
    else{
        echo "file is not entered !";
    }
}
?>

No matter what the code inside the if(check) statement, file get uploaded

in my view you have to write if($valueOne == "1212"){ in place of if($valueOne != "1212"){ — Vikas Umrao
– Vikas Umrao, Commented Feb 21, 2017 at 6:40

Ravi Hirani · Accepted Answer · 2017-02-21 06:50:05Z

1

Rewrite your code as below:-

if(!empty($_POST["submit"]) && !empty($_POST["filepassword"]) && !empty($_FILES['fileToUpload'])){
    $valueOne =trim($_POST["filepassword"]);
    $target_dir = "uploads/";
    $target_file = $target_dir . basename($_FILES["fileToUpload"]["name"]);
    if($valueOne == "1212"){ // if password is 1212 then file will upload.
    // make sure you want to check == or !=
          move_uploaded_file($_FILES["fileToUpload"]["tmp_name"], $target_file);
          echo "file uploaded successfully !";
    }
    else{
          echo "file is not entered !";
    }   
}

edited Feb 21, 2017 at 6:50

answered Feb 21, 2017 at 6:38

Ravi Hirani

6,5341 gold badge31 silver badges43 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

silvachathura Over a year ago

it says file is not entered when you upload the file with correct password !

Ravi Hirani Over a year ago

okay. then you should check == instead of !=. Please check my updated answer.

silvachathura Over a year ago

got it.. you have to change "$valueOne != "1212"" into "$valueOne == "1212"" ... not its workin g

Ravi Hirani Over a year ago

check this link:- meta.stackexchange.com/questions/5234/…

siddhesh kadam · Accepted Answer · 2017-02-21 06:49:47Z

0

Just Swap the code within if and else

if($valueOne != "1212"){
    echo "file is not entered !";
     }
     else{  
     move_uploaded_file($_FILES["fileToUpload"]["tmp_name"], $target_file);
     echo "file uploaded successfully !";
     }

answered Feb 21, 2017 at 6:49

siddhesh kadam

11 bronze badge

Collectives™ on Stack Overflow

PHP File Upload upload the file even if statement is not correct

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related