mysql table not deleting values

Question

I have a mysql data table that holds user information such as name,department,extension and phone number

Now I have a delete query that deletes a user based on the extension number the admin enters.

It was working yesterday and I have not changed a thing so I have no idea what could be wrong.

According to my code it must delete the user and then display the table. Now it does all that but the user still exists.

<?php
error_reporting(0);
require ("database.php");
session_start();
if (!isset($_SESSION['CheckLogin'])) { header("Location: login.php"); }
if($_POST['action'])
{
    $this_user_ext =$_GET['extension'];
    // sending query
    mysql_query("DELETE FROM users WHERE extension = '$this_user_ext'")
        or die(mysql_error());
    include('maildelete.php');
    $extension=$_POST['extension'];
    header("Location: index.php");
}
?>
<center>
    <form action="" method="post">
        Enter 4 Digit Extension Number :
        <br>
        <input type="text" name="extension">
        <br>
        <h2>
            <input type="submit" name="action" value="Delete Extension">
            <br>
        </h2>
        <h3>
            <a href="index.php"> Main Menu </a>
        </h3>
    </form>
</center>

don't use deprecated+removed version mysql_*. turn to mysqli_* or PDO along with prepared statements — Death-is-the-real-truth
– Death-is-the-real-truth, Commented Feb 21, 2017 at 6:49
You are wide open to SQL Injections and should really use Prepared Statements instead of concatenating your queries. Specially since you're not escaping the user inputs at all!. You can use Prepared Statements when you stop using the deprecated and insecure mysql_*-api and start using MySQLi or PDO. — M. Eriksson
– M. Eriksson, Commented Feb 21, 2017 at 6:51
Try POST Instead of GET $this_user_ext =$_POST['extension']; Because your form method is post. — user247217
– user247217, Commented Feb 21, 2017 at 6:52

Vikas Umrao · Accepted Answer · 2017-02-21 06:56:18Z

4

You have used POST method but you are using $_GET so

change $this_user_ext =$_GET['extension']; to $this_user_ext =$_POST['extension'];

edited Feb 21, 2017 at 6:56

answered Feb 21, 2017 at 6:50

Vikas Umrao

2,5801 gold badge17 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Norlihazmey Ghazali · Accepted Answer · 2017-02-21 06:52:00Z

0

Inside your form's tag having a method POST. You're sending the POST request, not the GET request. Use this code instead $this_user_ext = $_POST['extension'];

answered Feb 21, 2017 at 6:52

Norlihazmey Ghazali

9,0701 gold badge26 silver badges42 bronze badges

Comments

Kaushik solanki · Accepted Answer · 2017-02-21 06:53:57Z

0

 <?php
error_reporting(0);
require ("database.php");

session_start();
if (!isset($_SESSION['CheckLogin'])) { header("Location: login.php"); }



    if($_POST['action'])
{

$this_user_ext =$_POST['extension'];

    // sending query
    mysql_query("DELETE FROM users WHERE extension = '".$this_user_ext."'")
    or die(mysql_error());


include('maildelete.php');

$extension=$_POST['extension'];

header("Location: index.php");
}
?>
<center><form action="" method="post">
Enter 4 Digit Extension Number :<br><input type="text" name="extension">
<br><h2><input type="submit" name="action" value="Delete Extension">
<br></h2>
<h3>
<a href="index.php"> Main Menu </a>
</h3>
</form>
</center>

I hope U got it :) Enjoy..

answered Feb 21, 2017 at 6:53

Kaushik solanki

4381 gold badge3 silver badges15 bronze badges

1 Comment

M. Eriksson Over a year ago

A good answer includes an explanation, not just a bunch of code.

Collectives™ on Stack Overflow

mysql table not deleting values

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related