Populating array with new objects inside a loop

Question

I'm trying to fill an array with new objects, but the only thing I get is - Uncaught TypeError: product is not a constructor
Here's my code for obj. constructor:

function product(id, preview, colors, sizes, title, price) {
    this.id = id;
    this.preview = preview;
    this.colors = colors;
    this.sizes = sizes;
    this.title = title;
    this.price = price;
};

and code for loop:

    var products = [];
    for( i=0; i<db.length; i++) {
        var xyz = db[i];
        products[i] = new product( xyz.id, xyz.preview, xyz.colors, xyz.sizes, xyz.title, xyz.price );
    };

here's "minfied" code block example: https://jsfiddle.net/cujrfhyL/1/

-Thanks in advance.

Any chance you could provide a minimal verifiable complete example? — Icepickle
– Icepickle, Commented Feb 22, 2017 at 15:14
Please provide a snippet that reproduces the issue so it would be easier to help you. — Ronen Cypis
– Ronen Cypis, Commented Feb 22, 2017 at 15:19
actually in the editted code, you should use new product() ;) Except for the fact that product6566 and product6646 could throw syntaxerror as they are undefined, but I am guessing that is a typo — Icepickle
– Icepickle, Commented Feb 22, 2017 at 15:20
jsfiddle.net/Mistalis/j40parjq Just add new when creating a product. — Mistalis
– Mistalis, Commented Feb 22, 2017 at 15:24

ayinloya · Accepted Answer · 2017-02-22 15:46:31Z

2

If products array variable already has some kind of data, it's better you use the array push as not to override the data it contains

var product1 = { id: 6566, price: 3 };
var product2 = { id: 6566, price: 3 };		
var product3 = { id: 6568, price: 3 };	

var db = [ product1, product2 ];

function product(id, price) {
	this.id = id;
	this.price = price;
};

var products = [new product(product3.id,product3.price)];

function addProducts() {
	for( i=0; i<db.length; i++) {
		var xyz = db[i];
		products.push(new product( xyz.id, xyz.price ));
	}
  console.log(products)
};

addProducts();

answered Feb 22, 2017 at 15:46

ayinloya

1342 silver badges6 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Abhinav Galodha · Accepted Answer · 2017-02-22 15:31:52Z

1

You need to use the new operator.

products[i] = new product( xyz.id, xyz.price );

var product1 = { id: 6566, price: 3 };
var product2 = { id: 6566, price: 3 };		

var db = [ product1, product2 ];

function product(id, price) {
	this.id = id;
	this.price = price;
};

var products = [];

function addProducts() {
	for( i=0; i<db.length; i++) {
		var xyz = db[i];
		products[i] = new product( xyz.id, xyz.price );
		alert(products[i]);
	}
};

addProducts();

answered Feb 22, 2017 at 15:31

Abhinav Galodha

9,9862 gold badges33 silver badges41 bronze badges

Comments

Mayday · Accepted Answer · 2017-02-22 15:44:14Z

0

Don't know if you are having your same problem on local, but in your fiddle you misstyped:

Written there:

var product1 = { id: 6566, price: 3 };
var product2 = { id: 6566, price: 3 };  
var db = [ product6566, product6646 ];

But you need to reference product1 and product2 in db:

var db = [ product1, product2 ];

Appart from that, you need to use the "new" keyword:

your code:

products[i] = product( xyz.id, xyz.price );

Correct code:

products[i] = new product( xyz.id, xyz.price );

In Updated working fiddle you can see it working perfectly

answered Feb 22, 2017 at 15:44

Mayday

5,2165 gold badges27 silver badges65 bronze badges

Collectives™ on Stack Overflow

Populating array with new objects inside a loop

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related