How do i change value of variable from another java class?

Question

I am new to java so help is much appreciated.

I have a few classes. I want to pass the user input from my GUI class to my Basket class where it will update the value stored in the variable. Below is what i currently have but it doesn't seem to be updating the variable.

Class One - GUI Class: I would like to pass the 'seats' to the basket class

Basket b;
b = new Basket();   
String seats = JOptionPane.showInputDialog("Enter the number of seats to book");
try {
    int currentValue = Integer.parseInt(seats);
    int newValue = currentValue;    
    b.setSeatsBooked(newValue);
    //some code emitted
}

Second Class - Basket Class, I would like the 'seats' to be passed into this class and stored in the instance variable.

public class Basket {
    private int seatsBooked;
    public int getSeatsBooked() {
        return seatsBooked;
    }
    public void setSeatsBooked(int seatsBooked) {
        this.seatsBooked = seatsBooked;
    }
}

This is in another class where i see the result as 0:

Basket b;
b = new Basket();
lblMovieSelection = new JLabel("You have booked:" + b.getSeatsBooked());

what are you getting as output for the input you are using....???? — ΦXocę 웃 Пepeúpa ツ
– ΦXocę 웃 Пepeúpa ツ, Commented Feb 23, 2017 at 19:48
@WasiAhmad Please see my updated code as im trying to see that variable in another class where it is showing 0. — pogba123
– pogba123, Commented Feb 23, 2017 at 19:51

ΦXocę 웃 Пepeúpa ツ · Accepted Answer · 2017-02-23 19:52:25Z

3

This is the reason of the wrongly behaviour:

Basket b;
b = new Basket();

lblMovieSelection = new JLabel("You have booked:" + b.getSeatsBooked());

you are creating a new object! so the default value is zero for that

answered Feb 23, 2017 at 19:52

ΦXocę 웃 Пepeúpa ツ

48.4k17 gold badges77 silver badges102 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

pogba123 Over a year ago

Yes i just realised. So how would i fix this?

ΦXocę 웃 Пepeúpa ツ Over a year ago

for the third class you need to pass that value as parameter,,,

Chris Sharp Over a year ago

You could also pass the reference variable 'b' to the third class, especially if you're going to use it's properties/methods for anything else there.

Wasi Ahmad · Accepted Answer · 2017-02-23 20:11:28Z

2

You need to pass the class object for which you have stored the value. If you create a new instance of a class, how can you expect that object will contain that value?

In the following two cases,

Basket b;
b = new Basket();   
String seats = JOptionPane.showInputDialog("Enter the number of seats to book");
try {
    int currentValue = Integer.parseInt(seats);
    int newValue = currentValue;    
    b.setSeatsBooked(newValue);
    //some code emitted
}

and

Basket b;
b = new Basket();
lblMovieSelection = new JLabel("You have booked:" + b.getSeatsBooked());

Are the object b of class Basket same in both blocks? Answer is No. So, you are getting zero value when you call b.getSeatsBooked() from the newly created object b of class Basket in the second block of code.

There are two way to solve this problem.

Best solution is to pass the class object (as parameter) to the third class where you are calling the getSeatsBooked() method.

Example: Suppose your another class is X and there is a function called method(). Then you can pass Basket class object as parameter to that function where you can access it to get the updated value. The code may look like as follows.

class X{
    // other code
    public void method(Basket b){
        lblMovieSelection = new JLabel("You have booked:" + b.getSeatsBooked());
    }
}

If you want share the variable seatsBooked across all class instances, you can declare the variable as static. (I guess this is not what you are looking for)

edited Feb 23, 2017 at 20:11

answered Feb 23, 2017 at 19:55

Wasi Ahmad

38.1k34 gold badges129 silver badges169 bronze badges

1 Comment

pogba123 Over a year ago

Yeah ok i think first solution is better. But im stuck on how to pass the variable to my third class. Do you have any example of how it works because i cant find any on internet.

DrBrad · Accepted Answer · 2017-02-23 19:53:39Z

-1

Try making the variable static, an example for this would be:

public static int testInt = 0;

The way you would call this in the other class is up to you, there are 2 options that you can use.

//NOT CLASS NAME IS FOR YOUR ACTUAL CLASS NAME.
ClassName varName = new ClassName();
varname.testInt;

//OR YOU CAN USE
ClassName.testInt;

edited Feb 23, 2017 at 19:53

answered Feb 23, 2017 at 19:50

DrBrad

3052 silver badges13 bronze badges

4 Comments

RAZ_Muh_Taz Over a year ago

variables don't have to be static in order to be passed to another object

DrBrad Over a year ago

Thats the part that you are going to downvote me on..?

Chris Sharp Over a year ago

He's using a public setter and passing the captured integer to that. This answer is completely wrong.

DrBrad Over a year ago

You can avoid using public setters its up to him I explained that.

Collectives™ on Stack Overflow

How do i change value of variable from another java class?

3 Answers 3

3 Comments

1 Comment

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

1 Comment

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related