Call service from controller in AngularJS

Question

I am very new to AnjularJs so bear with me. In my current code various controller are using same methods. Methods have been pasted on each controller which is not good practice. But now I want to share those methods between various controller as a CommonUtility.js In order to do that I need to make service or factory that much I got looking online. But not sure how? See below code if you can tell me what to do here. filename: Controller.js

(function(){ 
  var somecontrollers = angular.module('angular'); 
  somecontrollers.controller('NameofController', function ($scope, $http) {
    //code
    ..
    ..
    ..
  });
})();

Filename: CommonUtilities.js

var CommonUtilities = angular.module('CommonUtilities', [])
  .service('Collapse', function () {
    this.CollapseTree = function () {
      var name 
      return name
    }
    method2
    method3
    ...
  });

How do I add reference to commonUtilities.js or its methods in Controller.js? Any help is appreciated. Also one more question. How do I use $scope in CollapseTree function? Thanks.

Pop-A-Stash · Accepted Answer · 2017-02-24 22:10:28Z

1

Write it like this so it's very clear:

(function(){ 
  'use strict';

  var somecontrollers = angular.module('angular', ['CommonUtilities']); 
  somecontrollers.controller('NameofController', NameofController);

  NameofController.$inject = ['$scope', '$http', 'Collapse'];

  function NameofController($scope, $http, Collapse) {
    Collapse.CollapseTree();
  });
}();

You simply reference it by the name you gave it earlier. Also, be sure to include the module that contains your service.

You cannot use $scope in a service. $scope is strictly for controllers as a way to reference methods and variables in a view.

edited Feb 24, 2017 at 22:10

answered Feb 24, 2017 at 22:04

Pop-A-Stash

6,6975 gold badges30 silver badges54 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Call service from controller in AngularJS

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related