Return valid Json array

Question

I'm fairly new to Json and arrays and I'm just wondering whether someone can correct the code I've tried that is still outputting an invalid string.

$json = array(
    'posts' => array(),
);

    while($row = mysqli_fetch_array($result)) {
        $posts = array();
        $posts['count'] = $rowcount;
     $posts['streamitem_id'] = $row['streamitem_id'];


$json['posts'] = $posts;
echo json_encode($json);
}

I have used http://jsonlint.com/ and posted my returned data from firebug errors on lines 6,11 and 16 } {

  {
    "posts": {
        "count": 4,
        "streamitem_id": "1976"
    }
} {
    "posts": {
        "count": 4,
        "streamitem_id": "1980"
    }
} {
    "posts": {
        "count": 4,
        "streamitem_id": "1099"
    }
} {
    "posts": {
        "count": 4,
        "streamitem_id": "1178"
    }
}

$rowcount has been initialised.by $rowcount = mysqli_num_rows($result); just below my query - It wasn't relevent, just added it as it was a varaible that needed to be passed through the json array. Also the lines can be counted from the first line to the last and it will give you the problem lines which are the opening and closing brackets which are now lines 6,11 and 16 — Gateway
– Gateway, Commented Feb 27, 2017 at 22:07

Timothy Wood · Accepted Answer · 2017-02-27 22:10:55Z

2

Some have already commented with a valid answer however, I believe array_push is the most efficient method rather than redefining the $posts variable over and over.

$json = array(
    'posts' => array()
);

while($row = mysqli_fetch_array($result)) {
    array_push($json['posts'], $array(
        'count' => $rowcount,
        'streamitem_id' => $row['streamitem_id']
        )
    );
}
echo json_encode($json);

PS: I noticed that you're putting $rowcount in each post array. If this is not intended, I recommend the following change:

$json = array(
    'posts' => array(),
    'count' => $rowcount
);

And then in the while loop:

    array_push($json['posts'], $array(
        'streamitem_id' => $row['streamitem_id']
        )
    );

This way, you can reference the post count and it won't be a waste of memory.

console.log(json['count']);

edited Feb 27, 2017 at 22:10

answered Feb 27, 2017 at 22:05

Timothy Wood

4873 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Timothy Wood Over a year ago

@Gateway No problem. I made an edit to account for one more thing.

Gateway Over a year ago

Nice little edit there. Returned string now looks like this ` { "posts": [{ "streamitem_id": "1976" }, { "streamitem_id": "1980" }, { "streamitem_id": "1099" }, { "streamitem_id": "1178" }], "count": 4 }`

Gateway Over a year ago

Accepted your answer. Brownie points for going the extra mile with the other part.

AbraCadaver Over a year ago

Probably easier: $json['posts'][] = array('streamitem_id' => $row['streamitem_id']);

Timothy Wood Over a year ago

Another way to do this (for even further optimization) is to avoid even storing the 'streamitem_id' key at all. Simply: array_push($json['posts'], $row['streamitem_id']); I only say this because you already know that 'posts' contains the stream item ids. Your js object should then look like this: {"posts":["1976","1980","1099","1178"], "count":4} PS: It appears that $json['posts'][] may be faster by microseconds. I recommend doing some research on this if you're interested.

|

Ray O'Donnell · Accepted Answer · 2017-02-27 22:03:32Z

1

I think you want this:

$posts = array();
$rowcount = 0;
while ($row = mysqli_fetch_array($result)) {
    $posts[] = array(
       'count' => $rowcount,
       'streamitem_id' = $row['streamitem_id'],
    );
    $rowcount++;
}

$json['posts'] = $posts;
echo json_encode($json);

answered Feb 27, 2017 at 22:03

Ray O'Donnell

7814 silver badges12 bronze badges

Comments

Niklesh Raut · Accepted Answer · 2017-02-27 22:09:18Z

1

Put this outside of loop, you are overwriting and echoing each value instead whole at once

Inside loop

      $posts[] = ["count"=> $rowcount,"streamitem_id"=>$row['streamitem_id']);

After loop

  $json['posts'] = $posts;
  echo json_encode($json);

edited Feb 27, 2017 at 22:09

answered Feb 27, 2017 at 22:01

Niklesh Raut

34.9k17 gold badges82 silver badges112 bronze badges

2 Comments

Gateway Over a year ago

Hi @Niklesh this is now valid json but only returns one record instead of the 4 I've requested within the loop. How can I fix this? Thank you

Niklesh Raut Over a year ago

Updated my answer

Collectives™ on Stack Overflow

Return valid Json array

3 Answers 3

6 Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

6 Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related