Access variables from App Delegate in View Controller

Question

I am implementing Google sign in on my app and I need to access the User ID and first/last name. The variables storing that data are in the App Delegate. I have searched the internet inside and out looking for how to do this in Swift 3, and there is absolutely nothing.

Here's the App Delegate (at least the part that matters):

class AppDelegate: UIResponder, UIApplicationDelegate, GIDSignInDelegate {

var window: UIWindow?
var databaseRef: FIRDatabaseReference!

var userID = String()
var givenName = String()
var familyName = String()

func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?) -> Bool {
    // Override point for customization after application launch.

    // Use Firebase library to configure APIs
    FIRApp.configure()

    GIDSignIn.sharedInstance().clientID = FIRApp.defaultApp()?.options.clientID
    GIDSignIn.sharedInstance().delegate = self

    return true
}

func application(_ app: UIApplication, open url: URL, options: [UIApplicationOpenURLOptionsKey : Any] = [:]) -> Bool {

    return GIDSignIn.sharedInstance().handle(url,
                                             sourceApplication: options[UIApplicationOpenURLOptionsKey.sourceApplication] as? String,
                                             annotation: options[UIApplicationOpenURLOptionsKey.annotation])
}

func sign(_ signIn: GIDSignIn!, didSignInFor user: GIDGoogleUser!, withError error: Error!) {

    if let error = error {
        print(error.localizedDescription)
        return
    }
    print("User signed into Google")

    let authentication = user.authentication
    let credential = FIRGoogleAuthProvider.credential(withIDToken: (authentication?.idToken)!,
                                                      accessToken: (authentication?.accessToken)!)

    FIRAuth.auth()?.signIn(with: credential) { (user, error) in
        print("User Signed Into Firebase")


        self.databaseRef = FIRDatabase.database().reference()

        self.databaseRef.child("user_profiles").child(user!.uid).observeSingleEvent(of: .value, with: { (snapshot) in

            let snapshot = snapshot.value as? NSDictionary

            if(snapshot == nil)
            {
                self.databaseRef.child("user_profiles").child(user!.uid).child("name").setValue(user?.displayName)
                self.databaseRef.child("user_profiles").child(user!.uid).child("email").setValue(user?.email)
            }


        })

    }

    userID = user.userID
    givenName = user.profile.givenName
    familyName = user.profile.familyName


    continueToWallet()
}

In the View Controller, I am calling the App delegate and trying to receive the data, but it gives me an error saying, "Instance member 'User ID' cannot be used on type 'AppDelegate'"

class addToWalletController: UIViewController {

var ID = String()

let delegate = UIApplication.shared.delegate as! AppDelegate
let user = AppDelegate.userID
let firstName = AppDelegate.givenName
let lastName = AppDelegate.familyName

override func viewDidLoad() {
    super.viewDidLoad()
}

}

I have also tried switching AppDelegate with delegate in the =AppDelegate.userID but it gives me the same error. What's going on?

AlvinZhu · Accepted Answer · 2017-03-01 03:21:30Z

24

The error message have told you property initializers run before 'self' is available.

Maybe you should initialize it in viewDidLoad

let delegate = UIApplication.shared.delegate as! AppDelegate
var user: String?
var firstName: String?
var lastName: String?

override func viewDidLoad() {
    super.viewDidLoad()

    user = delegate.userID
    firstName = delegate.givenName
    lastName = delegate.familyName
}

answered Mar 1, 2017 at 3:21

AlvinZhu

4486 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Samantha · Accepted Answer · 2017-03-01 03:22:11Z

13

AppDelegate is the class. What you want is the instance of AppDelegate that is your application's delegate. In addition, you can't use the delegate constant you've declared to set the values of other instance members because it is also an instance member itself.

I like to implement a function in AppDelegate like this:

static func shared() -> AppDelegate {
    return UIApplication.shared.delegate as! AppDelegate
}

And then I can just call it from elsewhere like so:

let firstName = AppDelegate.shared().givenName

Another option would be to set the values of these properties using the delegate property you have defined, but do it later such as in viewDidLoad, such as Alvin's answer suggests.

answered Mar 1, 2017 at 3:22

Samantha

2,2992 gold badges15 silver badges25 bronze badges

Comments

jLaszczewski · Accepted Answer · 2017-09-15 13:06:07Z

1

You can also made something similar to UIApplication.shared.... Than you have to add this to AppDelegates:

open class var shared: AppDelegate {
    get {
        return UIApplication.shared.delegate as! AppDelegate
    }
}

or something like this:

public class var shared: AppDelegate {
    return UIApplication.shared.delegate as! AppDelegate
}

Than you have Swift 3.x syntax :)

Cheers!

edited Sep 15, 2017 at 13:06

answered Sep 15, 2017 at 12:59

jLaszczewski

992 silver badges6 bronze badges

Comments

ozanonurtek · Accepted Answer · 2017-12-13 00:05:40Z

1

Update: You don't need to access Appdelegate for GoogleSignIn. Use following code in your button action

 @IBAction func loginWithGoogle(_ sender: Any) {
    GIDSignIn.sharedInstance().uiDelegate = self
    GIDSignIn.sharedInstance().signIn()
    //Be sure that you are signed-in
    if(GIDSignIn.sharedInstance().hasAuthInKeychain()){
        print("Signed-in")
        //Use currentUser attribute.
        print(GIDSignIn.sharedInstance().currentUser.profile.email)
    }
}

answered Dec 13, 2017 at 0:05

ozanonurtek

3165 silver badges19 bronze badges

Comments

Myrenkar · Accepted Answer · 2018-08-02 06:49:30Z

0

You should never do it. You should have proper abstraction for handling sign in. App delegate should be private class. What is the point of using this shared state? Google sign in has convenient methods for handling this and user credentials should not be stored in app delegate. You can use some class or database if needed.

answered Aug 2, 2018 at 6:49

Myrenkar

931 silver badge4 bronze badges

Collectives™ on Stack Overflow

Access variables from App Delegate in View Controller

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related