Laravel dependency injection Auth::

Question

I have a laravel project with a CalendarService and I inject that service into my controller. In the constructer I do something like this:

CalendarService.php

/** @var Collection|Timelog[] */
private $timelogs;

public function __construct()
{
    $this->currentRoute = URL::to( '/' ) . "/home";
    $this->timelogs     = Auth::user()->timelogs()->get();
    $this->currentDay   = 0;
}

HomeController.php

/** @var CalendarService */
protected $calenderService;

public function __construct
(
    CalendarService $calendarService
)
{
    $this->calenderService = $calendarService;
}

And I get this error

Call to a member function timelogs() on null

About this line of code:

Auth::user()->timelogs()->get();

I have used the use Illuminate\Support\Facades\Auth; in my service

What is going on here?

Auth::user() empty means user is not logged in. are you sure the user is logged in? — Saumini Navaratnam
– Saumini Navaratnam, Commented Mar 1, 2017 at 15:46
@Nicolas hahaha ja echt retarded code ik heb een groot stuk gerefactored maar Laravel is echt wel retarded ik mag ni eens simpele services da ik heb geschreven injecteren in mijn controller... — Frank Lucas
– Frank Lucas, Commented Mar 1, 2017 at 15:57

apokryfos · Accepted Answer · 2017-03-01 16:23:09Z

2

The issue is (as pointed out in https://laracasts.com/discuss/channels/laravel/cant-call-authuser-on-controllers-constructor) the fact that the Auth middleware is not initialized during the controller construction phase.

You can instead do this though:

protected $calenderService;

public function __construct()
{ 
    $this->middleware(function ($request,$next) {        
         $this->calenderService = resolve(CalendarService::class);
         return $next($request);
     });
}

Alternative

public function controllerMethod(CalendarService $calendarService) { 
    //Use calendar service normally
}

Note: This assumes that you're able to resolve the CalendarService via the service container.

edited Mar 1, 2017 at 16:23

answered Mar 1, 2017 at 15:52

apokryfos

40.9k11 gold badges85 silver badges128 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Frank Lucas Over a year ago

This will probably throw an error that the method middleware doesnt exist

Frank Lucas Over a year ago

I don't want to do this in my controller btw I want to keep my controllers as clean as possible

apokryfos Over a year ago

@FrankLucas sorry I thought the first snippet was of the controller. The alternative to this is to inject the CalendarService object in the controller method. Updated.

Alexey Mezenin · Accepted Answer · 2017-03-01 15:49:42Z

0

You can't use auth() or Auth:: in a constructor in the latest versions of Laravel, so you'll need to use this logic directly in the method.

public function someMethod()
{
    $timelogs = Auth::user()->timelogs()->get();

answered Mar 1, 2017 at 15:49

Alexey Mezenin

164k27 gold badges309 silver badges287 bronze badges

Collectives™ on Stack Overflow

Laravel dependency injection Auth::

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related