Rails link_to ruby variable in onclick javascript

Question

What is Wrong with this statement It is showing syntax error

<%= link_to image_tag('cancel.png'), {:action => 'remove', :id => question.id}, :title=>'Delete', :class=>'action', :onclick=>"removeQuestion("+ question.id +");return false;"%>

But

<%= link_to image_tag('cancel.png'), {:action => 'remove', :id => question.id}, :title=>'Delete', :class=>'action', :onclick=>"removeQuestion();return false;"%>

is correctly generating the below code

<a title="Delete" onclick="removeQuestion();return false" class="action remove" href="/quizzes/remove/1"><img src="/images/cancel.png?1290165811" alt="Cancel"></a>

ALso please only tag the questions with the language, additional tags such as "helpers" / "link-to" are not helpful and are just tagspam :( — Ryan Bigg
– Ryan Bigg, Commented Nov 25, 2010 at 5:37

Chirantan · Accepted Answer · 2010-11-25 05:44:45Z

12

What you wrote

<%= link_to image_tag('cancel.png'), {:action => 'remove', :id => question.id}, :title=>'Delete', :class=>'action', :onclick=>"removeQuestion("+ question.id +");return false;"%>

This bombs because question.id is a Fixnum. You would get can't convert Fixnum into String TypeError.

Ways to solve this

<%= link_to image_tag('cancel.png'), {:action => 'remove', :id => question.id}, :title=>'Delete', :class=>'action', :onclick=>"removeQuestion("+ question.id.to_s +");return false;"%>

OR

<%= link_to image_tag('cancel.png'), {:action => 'remove', :id => question.id}, :title=>'Delete', :class=>'action', :onclick=>"removeQuestion('#{question.id}');return false;"%>

This will send the question id as a string to your removeQuestion javascript function.

OR

<%= link_to image_tag('cancel.png'), {:action => 'remove', :id => question.id}, :title=>'Delete', :class=>'action', :onclick=>"removeQuestion(#{question.id});return false;"%>

This will send the question id as an integer to your removeQuestion javascript function.

answered Nov 25, 2010 at 5:44

Chirantan

15.7k8 gold badges52 silver badges75 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

panzi Over a year ago

The last one will not send it as an integer but as an double, because JavaScript only knows double. Ok, it is compatible with 32bit integers, but still.

polaiah · Accepted Answer · 2013-05-01 06:15:35Z

1

 <%= link_to image_tag('cancel.png'), {:action => 'remove', :id => question.id}, :title=>'Delete', :class=>'action', :onclick=>"removeQuestion($(this).attr('id'));return false;"%>

This will work

answered May 1, 2013 at 6:15

polaiah

111 bronze badge

Collectives™ on Stack Overflow

Rails link_to ruby variable in onclick javascript

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related