batch script conditions on variables

Question

I want to use the first argument of my batch script as a variable. If it contains FULL I will set all my variables to 1 and if it's empty I will ask for each.

But I can't make my code work :

 @echo off
        color 02

    ::-----------------------------------------
    :: Variables
    set Preset=%1 
    set Profile=%2 
    set NeedToPassTheTests=1
    set PublishAPI=0

    REM ---------------------
REM We fill the variables depending on the arguments
echo(%1
if defined Preset (

if "%Preset%"=="FULL" (
echo FULL
set PublishOCPP=1
set NeedToPassTheTests=1 
set PublishAPI=1
)

) else (
    REM No preset so we are going to ask
    set /p PublishAPI="Publish API ? (0 or 1).............. ? "
    set /p NeedToPassTheTests="Test the projects before ? (0 or 1).............. ? "
)


echo NeedToPassTheTests %NeedToPassTheTests% 
echo %PublishAPI%

echo.
pause

I get

The syntax of the command is incorrect

And also my echo at the end are not printing the value (when I remove my ifs) it only displays echo is off.

I'm starting with .bat files, I've tried with only the is Empty test (taken from here : What is the proper way to test if variable is empty in a batch file? ) and it doesn't work either.

Do you know why ?

UPDATE : It works when I pass FULL as argument but my variables are not updated. however it the parameter is empty it doesn't work (ie doesn't ask me to fill the variables).

Don't use ::comment within a code block (parenthesised sequence of statements) - use rem The :: is a broken label and labels within code blocks can lead to unexpected results. — Magoo
– Magoo, Commented Mar 16, 2017 at 13:48
Use the syntax if "%varname%"=="value" (dothis) else (dothat) to compare strings which may contain separators like spaces or you'll get a syntax error. The quotes cause the contained values to be interpreted as a single string. — Magoo
– Magoo, Commented Mar 16, 2017 at 13:51
if "%Preset%"=="" also gives me an error with incorrect syntax :( — user2088807
– user2088807, Commented Mar 16, 2017 at 15:05
Please show the entire code line. What is the content of preset? — Magoo
– Magoo, Commented Mar 16, 2017 at 15:10
you may be interested to use choice instead of set /p: no wrong inputs possible. — Stephan
– Stephan, Commented Mar 16, 2017 at 16:53

MichaelS · Accepted Answer · 2017-03-16 13:49:53Z

1

I'm not sure which errors are in the code but I can see several bugs in a second.

set NeedToPassTheTests=1 will set the variable called NeedToPassTheTests to the value 1

set NeedToPassTheTests<space>=1 will set NeedToPassTheTests<space> to 1

set NeedToPassTheTests<space>=<space>1 will set NeedToPassTheTests<space> to <space>1.

So first of all, get rid of any unnecessary spaces.

answered Mar 16, 2017 at 13:49

MichaelS

6,0727 gold badges33 silver badges47 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Magoo · Accepted Answer · 2017-03-16 13:46:16Z

0

set NeedToPassTheTests = 1

Remove the spaces. Batch is sensitive to spaces on oth sides of the assignment - you are setting a variable named "NeedToPassTheTestsspace" to a value of "space1"

To test for variable var is empty:

if defined var (echo variable is not empty) else (echo variable is empty)

Quirk:

echo(%var%

will show the variable if it's not empty or an empty line if it is (not the echo status)

answered Mar 16, 2017 at 13:46

Magoo

80.8k8 gold badges68 silver badges92 bronze badges

4 Comments

user2088807 Over a year ago

I don't have an error anymore my bad. But when my variable is empty (no arguments passed, echo %1 show "ECHO is off" it's considered not empty.

Magoo Over a year ago

With an empty argument, echo shows the current echo status (on or off) Use echo(%1 (or echo(%potentiallyemptyvariable%) which will yield an empty line if the argument evaluates to nothing Note that the ( is required for this.

user2088807 Over a year ago

Yes it's empty :) But it doesn't go in the else, please see my update code

Magoo Over a year ago

Use the syntax like "set Preset=%1" on all string-set instructions. Your code contains trailing spaces on lines, so preset is being set to <kbd>Space</kbd> which is a little hard to see but is a value, so preset is defined. (and yes - this can be a real head-scratcher. Using the quotes becomes Pavlovian after you've spent hours trying to figure it out...)

Collectives™ on Stack Overflow

batch script conditions on variables

2 Answers 2

Comments

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related