c# SqlDataReader repeating final row of data

Question

I'm using an SqlDataReader to read to a collection of custom type , but all I'm getting is the final row of the DataTable repeated, rather than a full table of information. Help would be gratefully received.

using (connection)
        {

            using (SqlCommand command = new SqlCommand(query, connection))
            {
                using (SqlDataReader reader = command.ExecuteReader())
                {
                    while (reader.Read())
                    {
                        lineData.Column1 = reader.GetValue(0).ToString();
                        lineData.Column2 = reader.GetValue(1).ToString();
                        lineData.Column3 = reader.GetValue(2).ToString();
                        lineData.Column4 = reader.GetValue(3).ToString();
                        lineData.Column5 = reader.GetValue(4).ToString();
                        lineData.Column6 = reader.GetValue(5).ToString();
                        lineData.Column7 = reader.GetValue(6).ToString();
                        lineData.Column8 = reader.GetValue(7).ToString();
                        columnData.Add(lineData);
                    }
                }
            }
        }

 foreach (var item in columnData)
        {
            Label.Text += item.Column1.ToString() + item.Column2.ToString() + item.Column3.ToString() + item.Column7.ToString();
        }

the code seems to be fine... can you upload your results(such as screen shots). and where did you declare columnData and why outside the loops? — Lei Yang
– Lei Yang, Commented Mar 20, 2017 at 0:54

Lei Yang · Accepted Answer · 2017-03-20 00:56:14Z

1

lineData should be declared within while loop. If it was declared before the code you uploaded, then you're referencing the same instance for every data row. Try change code to following;

while (reader.Read())
                {
                    lineData = new LineData();//like that

answered Mar 20, 2017 at 0:56

Lei Yang

4,4357 gold badges41 silver badges69 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Christopher McEwan Over a year ago

Knew it was something dumb. Thanks!

Akhatran · Accepted Answer · 2017-03-20 16:29:27Z

0

lineData must be declared during the cycle at that time. If it is declared before the code you uploaded, you to the same instance for each row of data. Try to change the code on the following;

answered Mar 20, 2017 at 16:29

Akhatran

194 bronze badges

Collectives™ on Stack Overflow

c# SqlDataReader repeating final row of data

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related